- dev - passt

[PATCH v2 1/6] conf: Add --dhcp-opt command-line option
by Anshu Kumari 28 May '26

28 May '26

Introduce the --dhcp-opt flag that allows setting arbitrary DHCP options from command-line in the form of [Option CODE,VALUE]. This patch adds the option storage in struct ctx and CLI parsing; the type-aware value parser and DHCP reply injection follow in subsequent patches. Link: https://bugs.passt.top/show_bug.cgi?id=192 Signed-off-by: Anshu Kumari <anskuma(a)redhat.com> --- v2: - Added kerneldoc for @custom_opts, @custom_opts.code, @custom_opts.str, and @custom_opts_count in struct ctx - Removed len and val[255] fields from struct (moved to patch 3) - Removed braces from case 33, moved declarations (optcode, comma, end) to function scope - Renamed code → optcode to follow function-scope convention --- conf.c | 34 +++++++++++++++++++++++++++++++++- passt.h | 12 ++++++++++++ 2 files changed, 45 insertions(+), 1 deletion(-) diff --git a/conf.c b/conf.c index 029b9c7..89d2127 100644 --- a/conf.c +++ b/conf.c @@ -47,6 +47,7 @@ #include "lineread.h" #include "isolation.h" #include "log.h" +#include "dhcp.h" #include "vhost_user.h" #include "epoll_ctl.h" #include "conf.h" @@ -616,7 +617,8 @@ static void usage(const char *name, FILE *f, int status) " -S, --search LIST Space-separated list, search domains\n" " a single, empty option disables the DNS search list\n" " -H, --hostname NAME Hostname to configure client with\n" - " --fqdn NAME FQDN to configure client with\n"); + " --fqdn NAME FQDN to configure client with\n" + " --dhcp-opt CODE,VAL Set DHCP option by code\n"); if (strstr(name, "pasta")) FPRINTF(f, " default: don't use any search list\n"); else @@ -844,6 +846,10 @@ static void conf_print(const struct ctx *c) info(" router: %s", inet_ntop(AF_INET, &c->ip4.guest_gw, buf, sizeof(buf))); + for (i = 0; i < c->custom_opts_count; i++) + info(" option %u: %s", + c->custom_opts[i].code, + c->custom_opts[i].str); } for (i = 0; i < ARRAY_SIZE(c->ip4.dns); i++) { @@ -1233,6 +1239,7 @@ void conf(struct ctx *c, int argc, char **argv) {"migrate-no-linger", no_argument, NULL, 30 }, {"stats", required_argument, NULL, 31 }, {"conf-path", required_argument, NULL, 'c' }, + {"dhcp-opt", required_argument, NULL, 33 }, { 0 }, }; const char *optstring = "+dqfel:hs:c:F:I:p:P:m:a:n:M:g:i:o:D:S:H:461t:u:T:U:"; @@ -1248,10 +1255,13 @@ void conf(struct ctx *c, int argc, char **argv) uint8_t prefix_len_from_opt = 0; unsigned int ifi4 = 0, ifi6 = 0; const char *logfile = NULL; + unsigned long optcode; char *runas = NULL; size_t logsize = 0; + const char *comma; long fd_tap_opt; int name, ret; + char *end; uid_t uid; gid_t gid; @@ -1465,6 +1475,28 @@ void conf(struct ctx *c, int argc, char **argv) die("Can't display statistics if not running in foreground"); c->stats = strtol(optarg, NULL, 0); break; + case 33: + comma = strchr(optarg, ','); + if (!comma) + die("--dhcp-opt requires Option CODE,VALUE format"); + + optcode = strtoul(optarg, &end, 0); + if (end != comma || optcode < 1 || optcode > 254) + die("DHCP option code must be 1-254: %s", + optarg); + + if (c->custom_opts_count >= MAX_CUSTOM_DHCP_OPTS) + die("Too many --dhcp-opt entries (max %d)", + MAX_CUSTOM_DHCP_OPTS); + + c->custom_opts[c->custom_opts_count].code = optcode; + if (snprintf_check(c->custom_opts[c->custom_opts_count].str, + sizeof(c->custom_opts[0].str), + "%s", comma + 1)) + die("DHCP option value too long: %s", + comma + 1); + c->custom_opts_count++; + break; case 'd': c->debug = 1; c->quiet = 0; diff --git a/passt.h b/passt.h index 1726965..3a0816f 100644 --- a/passt.h +++ b/passt.h @@ -182,6 +182,10 @@ struct ip6_ctx { * @dns_search: DNS search list * @hostname: Guest hostname * @fqdn: Guest FQDN + * @custom_opts: User-specified DHCP options from --dhcp-opt + * @custom_opts.code: DHCP option code + * @custom_opts.str: Original string value from command line + * @custom_opts_count: Number of entries in @custom_opts * @ifi6: Template interface for IPv6, -1: none, 0: IPv6 disabled * @ip6: IPv6 configuration * @pasta_ifn: Name of namespace interface for pasta @@ -263,6 +267,14 @@ struct ctx { char hostname[PASST_MAXDNAME]; char fqdn[PASST_MAXDNAME]; +#define MAX_CUSTOM_DHCP_OPTS 32 + + struct { + uint8_t code; + char str[256]; + } custom_opts[MAX_CUSTOM_DHCP_OPTS]; + int custom_opts_count; + int ifi6; struct ip6_ctx ip6; -- 2.54.0

3 5

[PATCH v2 2/6] conf: Add --dhcp-boot command-line option
by Anshu Kumari 28 May '26

28 May '26

Introduce the --dhcp-boot flag that sets the boot file URL for network boot specially for ipxe. This patch adds the option storage and CLI parsing. Link: https://bugs.passt.top/show_bug.cgi?id=192 Signed-off-by: Anshu Kumari <anskuma(a)redhat.com> --- v2: - Removed separate dhcp_boot[PATH_MAX] field — --dhcp-boot foo now stores into custom_opts[] as code 67 (same as --dhcp-opt 67,foo) --- conf.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/conf.c b/conf.c index 89d2127..ae8ee26 100644 --- a/conf.c +++ b/conf.c @@ -618,6 +618,7 @@ static void usage(const char *name, FILE *f, int status) " a single, empty option disables the DNS search list\n" " -H, --hostname NAME Hostname to configure client with\n" " --fqdn NAME FQDN to configure client with\n" + " --dhcp-boot URL Boot file URL for network boot\n" " --dhcp-opt CODE,VAL Set DHCP option by code\n"); if (strstr(name, "pasta")) FPRINTF(f, " default: don't use any search list\n"); @@ -1239,6 +1240,7 @@ void conf(struct ctx *c, int argc, char **argv) {"migrate-no-linger", no_argument, NULL, 30 }, {"stats", required_argument, NULL, 31 }, {"conf-path", required_argument, NULL, 'c' }, + {"dhcp-boot", required_argument, NULL, 32 }, {"dhcp-opt", required_argument, NULL, 33 }, { 0 }, }; @@ -1475,6 +1477,18 @@ void conf(struct ctx *c, int argc, char **argv) die("Can't display statistics if not running in foreground"); c->stats = strtol(optarg, NULL, 0); break; + case 32: + if (c->custom_opts_count >= MAX_CUSTOM_DHCP_OPTS) + die("Too many DHCP options (max %d)", + MAX_CUSTOM_DHCP_OPTS); + + c->custom_opts[c->custom_opts_count].code = 67; + if (snprintf_check(c->custom_opts[c->custom_opts_count].str, + sizeof(c->custom_opts[0].str), + "%s", optarg)) + die("Boot file name too long: %s", optarg); + c->custom_opts_count++; + break; case 33: comma = strchr(optarg, ','); if (!comma) -- 2.54.0

3 4

[PATCH 0/2] Fix a Coverity reported socket leak
by David Gibson 28 May '26

28 May '26

I got coverity working for me again, version 2026.3.0. This pointed out a potentially fairly nasty socket leak in tcp_listen_handler(). Here's a series that fixes it. David Gibson (2): tcp, tcp_splice: Make helper for setting SO_LINGER socket option tcp: Don't leak sockets on error paths tcp.c | 42 ++++++++++++++++++++++++++---------------- tcp_conn.h | 3 +++ tcp_splice.c | 20 +++----------------- 3 files changed, 32 insertions(+), 33 deletions(-) -- 2.54.0

3 7

passt: new version 2026_05_26.038c51e available
by Stefano Brivio 27 May '26

27 May '26

The new version with tag 2026_05_26.038c51e includes the following changes: 038c51e vhost_user: Offer VIRTIO_NET_F_GUEST_CSUM 196a9e5 ip: Wrap CASE macro body in braces for pre-C23 compatibility da00969 tcp_splice: Simplify tracking of read/written bytes ac9814e tcp_splice: Clean up flow control path for splice forwarding bda8230 tcp_splice: Avoid missing EOF recognition while forwarding aa6b796 tcp_splice: Improve error reporting 21ea343 tcp_vu: Support multibuffer frames in tcp_vu_send_flag() feb9a11 tcp_vu: Support multibuffer frames in tcp_vu_sock_recv() f8cace2 tcp_vu: Build headers on the stack and write them into the iovec 92845dd tcp: Encode checksum computation flags in a single parameter dec66c0 udp: Pass iov_tail to udp_update_hdr4()/udp_update_hdr6() 9361b6b iov: Introduce IOV_PUSH_HEADER() macro 28ee143 udp_vu: Allow virtqueue elements with multiple iovec entries 76fd546 selinux: Allow pasta to create and use its control socket when started by Podman cea2d19 Makefile: Remove misleading comments on BASE_*FLAGS 5038f92 netlink: Fix comments to variables for netlink sockets and sequence d00255b netlink: Use regular request/response netlink socket for initial neighbour sync b64ef53 conf, repair, tap: Document reasons for blocking Unix sockets 5ef0fc4 tap: Report accept() errors 1d16476 treewide: Add SOCK_CLOEXEC to accept() calls that are missing it db798fc vhost-user: Centralise Ethernet frame padding in vu_collect() and vu_pad() de6387a tcp: Pass explicit data length to tcp_fill_headers() d83470f vu_common: Pass explicit frame length to vu_flush() 533ef11 pcap: Pass explicit L2 length to pcap_iov() aa78f63 checksum: Pass explicit L4 length to checksum functions 7cd5afb udp_vu: Pass iov explicitly to helpers instead of using file-scoped array ee0ba3f udp_vu: Move virtqueue management from udp_vu_sock_recv() to its caller d3a4868 vu_common: Move vnethdr setup into vu_flush() d7259ea iov: Add iov_memcpy() to copy data between iovec arrays a804574 iov: Introduce iov_memset() bcc3d37 util: Fix changes to assert_with_msg() 296d7e3 fwd_rule: Allow parsing * as a forwarding address 666ef9e fwd_rule: Don't attempt dual stack listen()s if only one IP family 8bb21e3 test: Add test for builds with -DNDEBUG e514945 Fix build with -DNDEBUG fd4b637 test: Extend exeter build tests to cover more recent binaries ab12293 lib/term: Quote tr character ranges to prevent glob expansion 9b1ef47 pesto: Run static checkers on pesto sources bf63970 passt-repair: Run static checkers 3c6e797 passt-repair: Simplify construction of Unix path from inotify 1254a1f passt-repair: Split out inotify handling to its own function a2a2f40 Makefile: Split static checker targets b356b62 cppcheck, clang-tidy: Static checkers don't need non-preprocessor flags fb9be08 Makefile: Split $(FLAGS) into cpp and cc components 88ce87e Makefile: Add header dependencies for secondary binaries 9015b76 Makefile: Remove unhelpful $(HEADERS) variable d4632a4 Makefile: Use common binary compilation rule 59b14b2 Makefile: Make conditional definition of $(BIN) clearer 1cd6276 Makefile: Use make variables for static checker configuration 4de7c38 clang-tidy: Suppress some new unhelpful new warnings 97e478b treewide: Make some additional variables static 90f175d packet, clang-tidy: Packet pool buffers are not NULL 7bafe71 clang-tidy: Suppress sscanf() warning harder a82a217 clang-tidy: Squash inconsistent brace warnings in foreach macros db02221 conf: Fix not-actually-const parameter to conf_runas() and conf_ugid() 5b3ca87 virtio: Reduce scope of variable 1e6b638 netlink: erromsg should be const in nl_status() https://passt.top/passt/log/?qt=range&q=2026_05_07.1afd4ed..2026_05_26.038c… Packages: - Alpine Linux: https://pkgs.alpinelinux.org/packages?name=passt - Arch Linux: https://www.archlinux.org/packages/extra/x86_64/passt/ https://archlinuxarm.org/packages/aarch64/passt https://archlinuxarm.org/packages/armv7h/passt - Chimera: https://pkgs.chimera-linux.org/packages?name=passt - Clear Linux: https://github.com/clearlinux-pkgs/passt/ - Copr (CentOS Stream, EPEL, Fedora, Mageia): https://copr.fedorainfracloud.org/coprs/sbrivio/passt/build/10514454/ permanent mirror: https://passt.top/builds/copr/0^20260526.g038c51e/ - Debian tracker: https://tracker.debian.org/pkg/passt - Fedora updates: https://bodhi.fedoraproject.org/updates/?packages=passt - Gentoo versions: https://packages.gentoo.org/packages/net-misc/passt - GNU Guix: https://packages.guix.gnu.org/packages/passt/ - Homebrew: https://formulae.brew.sh/formula/passt - NixOS: https://github.com/NixOS/nixpkgs/tree/nixos-unstable/pkgs/by-name/pa/passt - openSUSE: https://software.opensuse.org/package/passt - OpenMandriva: https://github.com/OpenMandrivaAssociation/passt/tree/master - PLD Linux: https://git.pld-linux.org/cgi-bin/gitweb.cgi?p=packages/passt.git - Solus: https://github.com/getsolus/packages/tree/main/packages/p/passt - Ubuntu tracker: https://launchpad.net/ubuntu/+source/passt - Void Linux: https://voidlinux.org/packages/?q=passt - Static builds: - Package for other RPM-based distributions, x86_64 only: https://passt.top/builds/latest/x86_64/passt-g038c51e-1.x86_64.rpm - x86_64 static binaries: https://passt.top/builds/latest/x86_64/ - Debian package, from x86_64 static build: https://passt.top/builds/latest/x86_64/passt_038c51e-1_all.deb -- Stefano

1 0

[PATCH v2 0/2] vhost-user, dhcp: Fix iPXE network boot over vhost-user
by Laurent Vivier 26 May '26

26 May '26

iPXE network boot over vhost-user was broken because passt unconditionally skipped TCP/UDP checksum computation, relying on VIRTIO_NET_HDR_F_DATA_VALID to tell the guest the checksums were valid. Linux guests happened to work because their virtio-net driver honours DATA_VALID regardless of feature negotiation, but iPXE verifies checksums strictly and never negotiates VIRTIO_NET_F_GUEST_CSUM. This series handles correctly VIRTIO_NET_F_GUEST_CSUM feature to fix that and adds a minimal --dhcp-boot option that populates the BOOTP/DHCP 'file' field, providing just enough for testing iPXE UDP and TCP support. This can be tested as following: - Create an ipxe file configuration cat > boot-alpine.ipxe <<EOF kernel http://dl-cdn.alpinelinux.org/alpine/v3.23/releases/x86_64/netboot/vmlinuz-… console=ttyS0,115200 alpine_repo=http://dl-cdn.alpinelinux.org/alpine/v3.23/main modloop=http://dl-cdn.alpinelinux.org/alpine/v3.23/releases/x86_64/netboot/… initrd http://dl-cdn.alpinelinux.org/alpine/v3.23/releases/x86_64/netboot/initramf… boot EOF - Start a web server in the same directory as boot-alpine.ipxe python -m http.server 8080 - Start passt: ./passt -f --dhcp-boot http://<host ip address>:8080/boot-alpine.ipxe --vhost-user - Start QEMU without boot disk but with passt as networking backend Based-on: 20260416161618.3826904-1-lvivier(a)redhat.com v2: - Added Reviewed-by from David Gibson on both patches - Rebased on top of v6 TCP series Laurent Vivier (2): vhost_user: Offer VIRTIO_NET_F_GUEST_CSUM dhcp: Add --dhcp-boot option to set boot filename in DHCP replies conf.c | 10 ++++++++++ dhcp.c | 5 ++++- passt.1 | 6 ++++++ passt.h | 1 + tcp_vu.c | 8 ++++++-- udp_vu.c | 7 ++++--- vhost_user.c | 1 + 7 files changed, 32 insertions(+), 6 deletions(-) -- 2.53.0

2 8

[PATCH] ip: Wrap CASE macro body in braces for pre-C23 compatibility
by Anshu Kumari 26 May '26

26 May '26

From: Jeskynar <jeskynar(a)gmail.com> Compiling on RHEL8 (gcc-8.5) gives an error in ip.c. ip.c:88:3: error: a label can only be part of a statement and a declaration is not a statement due to the use of static_assert. The fix is to surround it with {}. Link: https://bugs.passt.top/show_bug.cgi?id=201 Signed-off-by: Anshu Kumari <anskuma(a)redhat.com> --- ip.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ip.c b/ip.c index f2506bb..7b674e0 100644 --- a/ip.c +++ b/ip.c @@ -35,9 +35,9 @@ const char *ipproto_name(uint8_t proto) { switch (proto) { #define CASE(s) \ - static_assert(sizeof(s) <= IPPROTO_STRLEN, \ - "Increase IPPROTO_STRLEN to contain " #s); \ - return s; + {static_assert(sizeof(s) <= IPPROTO_STRLEN, \ + "Increase IPPROTO_STRLEN to contain " #s); \ + return s;} case IPPROTO_ICMP: CASE("ICMP"); case IPPROTO_TCP: -- 2.54.0

4 4

[PATCH v2 0/4] Fix race condition while closing spliced connections
by David Gibson 26 May '26

26 May '26

Fix bug 202, where a race condition could cause connections to be incorrectly reset in certain circumstances. Patch 2/4 is the bug fix proper. 1/4 improves error reporting and debugging messages in the vicinity. Patches 3..4/4 are some small cleanups I noticed in the area while working on the fix. Link: https://bugs.passt.top/show_bug.cgi?id=202 v2: * Formatting and comment fixes, per Stefano's review * Dropped patches 5 & 6 for now. I still think they're worthwhile, but are closely related to other oddities that need some work. I didn't want to delay the bugfix itself. David Gibson (4): tcp_splice: Improve error reporting tcp_splice: Avoid missing EOF recognition while forwarding tcp_splice: Clean up flow control path for splice forwarding tcp_splice: Simplify tracking of read/written bytes flow.h | 7 ++ log.h | 19 +++--- passt.c | 2 +- tcp_conn.h | 6 +- tcp_splice.c | 185 ++++++++++++++++++++++++++++++--------------------- tcp_splice.h | 2 +- 6 files changed, 129 insertions(+), 92 deletions(-) -- 2.54.0

2 6

[PATCH v7 0/4] vhost-user,tcp: Handle multiple iovec entries per virtqueue element
by Laurent Vivier 26 May '26

26 May '26

This is the TCP counterpart to the UDP multi-iov series. It converts the TCP vhost-user receive path from direct pointer arithmetic (via vu_eth(), vu_ip(), etc.) to the iov_tail abstraction, removing the assumption that all headers reside in a single contiguous buffer. With this series applied, the TCP path correctly handles virtio-net drivers that provide multiple buffers per virtqueue element (e.g. iPXE provides the vnet header in the first buffer and the frame payload in a second one), matching the support already present in the UDP path. Based-on: 20260520095526.21519-1-lvivier(a)redhat.com v7: - Use initializers for struct tcphdr - Rename reused 'payload' variable to 'l2frame' - Fix vu_pad() double-offset bug in tcp_vu_data_from_sock() - Remove redundant *elem_used = 0 before truncation loop - Add missing @vnlen to tcp_vu_send_dup() doc comment v6: - Rebase on v8 of UDP series (tcp_update_csum() takes dlen rather than l4len) v5: - Use l2len variable for pcap_iov() length in tcp_vu_send_flag() - Add braces - Move pcap_iov() before vu_flush() - Remove vu_flush() from tcp_vu_send_dup(), let the caller handle it v4: - fix error during rebase, s/vu_pad_len/vu_pad/ v3: - Rebased on top of [PATCH 00/10] vhost-user: Preparatory series for multiple iovec entries per virtqueue element v2: - add "tcp: Encode checksum computation flags in a single parameter" - remove IOV_PUT_HEADER()/with_header() and use IOV_PUSH_HEADER() - don't use the iov_tail to provide the headers to the functions Laurent Vivier (4): tcp: Encode checksum computation flags in a single parameter tcp_vu: Build headers on the stack and write them into the iovec tcp_vu: Support multibuffer frames in tcp_vu_sock_recv() tcp_vu: Support multibuffer frames in tcp_vu_send_flag() iov.c | 1 - tcp.c | 25 +-- tcp_buf.c | 23 +-- tcp_internal.h | 7 +- tcp_vu.c | 409 +++++++++++++++++++++++++++++-------------------- vu_common.h | 20 --- 6 files changed, 272 insertions(+), 213 deletions(-) -- 2.54.0

2 4

[PATCH v11 0/3] vhost-user,udp: Handle multiple iovec entries per virtqueue element
by Laurent Vivier 26 May '26

26 May '26

Some virtio-net drivers (notably iPXE) provide descriptors where the vnet header and the frame payload are in separate buffers, resulting in two iovec entries per virtqueue element. Currently, the RX (host to guest) path assumes a single iovec per element, which triggers: ASSERTION FAILED in virtqueue_map_desc (virtio.c:403): num_sg < max_num_sg This series reworks the UDP vhost-user receive path to support multiple iovec entries per element, fixing the iPXE crash. This series only addresses the UDP path. TCP vhost-user will be updated to use multi-iov elements in a subsequent series. v11: - Rebase on master - use sizeof(*uh) instead of sizeof(struct udphdr) in udp_tap_prepare() - improve @payload doc in udp_vu_sock_recv() - add R-b from David v10: - udp_update_hdr4()/udp_update_hdr6(): take separate @uh pointer and @payload - udp_tap_prepare(): extract uh from UDP_IOV_PAYLOAD, @payload is UDP payload only - udp_vu_sock_recv(): extract UDP payload from the function - udp_vu_prepare(): take @payload as parameter, compute checksum conditionally via !*c->pcap instead of hardcoded true - udp_vu_csum(): removed v9: - iov_push_header_(): skip memcpy() when the source pointer already aliases the iov buffer - udp_update_hdr4()//udp_update_hdr6()/usp_csum(): update payload doc - udp_tap_prepare(): use existing (*tap_iov)[UDP_IOV_PAYLOAD] v8: - Add Reviewed-by from David for 1/3 and 2/3 - Remove VLA to use fixed size (VIRTQUEUE_MAX_SIZE) - Rename udp_frame to datagram - Use sizeof(uh) instead of sizeof(struct udphdr) - Push back uh in memory in udp_vu_csum() v7: - In udp_vu_sock_to_tap(), introduce iov_still_needed variable - Fix iov_tail @data doc comments in udp_vu_prepare()/udp_vu_csum() - Don't rewrap the virtio checksum comment in udp_update_hdr6() - Add NULL check for uh in udp_vu_csum() v6: - Rebased on top of [PATCH 00/10] vhost-user: Preparatory series for multiple iovec entries per virtqueue element v5: - This version doesn't change the padding system regarding v4, it's a complex task that will be addressed in another version - reorder patches and add new patches - remove IOV_PUT_HEADER()/with_header() and introduce IOV_PUSH_HEADER() - don't use the iov_tail to provide the headers to the functions - move vu_set_vnethdr() to vu_flush(), extract vu_queue_notify() - move vu_flush() inside loop in tcp_vu_data_from_sock() to flush data by frame and not by full data length v4: - rebase - replace ASSERT() by assert() v3: - include the series "Decouple iovec management from virtqueues elements" - because of this series, drop: "vu_common: Accept explicit iovec counts in vu_set_element()" "vu_common: Accept explicit iovec count per element in vu_init_elem()" "vu_common: Prepare to use multibuffer with guest RX" "vhost-user,udp: Use 2 iovec entries per element" - drop "vu_common: Pass iov_tail to vu_set_vnethdr()" as the specs insures a buffer is big enough to contain vnet header - introduce "with_header()" and merge "udp: Pass iov_tail to udp_update_hdr4()/udp_update_hdr6()" and "udp_vu: Use iov_tail in udp_vu_prepare()" to use it v2: - add iov_truncate(), iov_memset() - remove iov_tail_truncate() and iov_tail_zero_end() - manage 802.3 minimum frame size Laurent Vivier (3): udp_vu: Allow virtqueue elements with multiple iovec entries iov: Introduce IOV_PUSH_HEADER() macro udp: Pass iov_tail to udp_update_hdr4()/udp_update_hdr6() iov.c | 30 ++++++++++++ iov.h | 11 +++++ udp.c | 74 ++++++++++++++-------------- udp_internal.h | 6 ++- udp_vu.c | 129 +++++++++++++++++++------------------------------ 5 files changed, 131 insertions(+), 119 deletions(-) -- 2.54.0

2 1

[PATCH] Makefile: Remove misleading comments on BASE_*FLAGS
by David Gibson 26 May '26

26 May '26

I added these comments attempting to describe the difference between BASE_CFLAGS and CFLAGS. However, the description given isn't really accurate, and I'm not even sure the concept I'm trying to describe is coherent. Just remove it. Suggested-by: Stefano Brivio <sbrivio(a)redhat.com> Signed-off-by: David Gibson <david(a)gibson.dropbear.id.au> --- Makefile | 4 ---- 1 file changed, 4 deletions(-) diff --git a/Makefile b/Makefile index c4af57b4..0a0a60b0 100644 --- a/Makefile +++ b/Makefile @@ -30,15 +30,11 @@ ifeq ($(shell $(CC) -O2 -dM -E - < /dev/null 2>&1 | grep ' _FORTIFY_SOURCE ' > / FORTIFY_FLAG := -D_FORTIFY_SOURCE=2 endif -# Mandatory preprocessor flags that won't be overridden with $(CPPFLAGS) -# FIXME: Could some of these be default, rather than required? BASE_CPPFLAGS := -D_XOPEN_SOURCE=700 -D_GNU_SOURCE $(FORTIFY_FLAG) BASE_CPPFLAGS += -DPAGE_SIZE=$(shell getconf PAGE_SIZE) BASE_CPPFLAGS += -DVERSION=\"$(VERSION)\" BASE_CPPFLAGS += -DDUAL_STACK_SOCKETS=$(DUAL_STACK_SOCKETS) -# Mandatory compiler flags that won't be overridden with $(CFLAGS) -# FIXME: Could some of these be default, rather than required? BASE_CFLAGS := -std=c11 -pie -fPIE -O2 BASE_CFLAGS += -pedantic -Wall -Wextra -Wno-format-zero-length -Wformat-security -- 2.54.0

2 1