- dev - passt

[PATCH 0/4] Even more flow table preliminaries
by David Gibson 14 Jun '24

14 Jun '24

I hoped that the last batch was the last, but I was wrong. Working on UDP flow has shown up a few more things that make sense to do before taking the leap into full flow table implementation. Here's what I have so far, though there could be even more. David Gibson (4): util: Split construction of bind socket address from the rest of sock_l4() udp: Fold checking of splice flag into udp_mmh_splice_port() udp: Rework how we divide queued datagrams between sending methods udp: Move management of udp[46]_localname into udp_splice_send() udp.c | 175 ++++++++++++++++++++++++++++++++------------------------- util.c | 123 +++++++++++++++++++++++----------------- 2 files changed, 170 insertions(+), 128 deletions(-) -- 2.45.1

2 10

[PATCH v6 0/8] Add vhost-user support to passt (part 2)
by Laurent Vivier 13 Jun '24

13 Jun '24

Extract buffers management code from tcp.c and move it to tcp_buf.c tcp.c keeps all the generic code and will be also used by the vhost-user functions. Also compare mode to MODE_PASTA, as we will manage vhost-user mode (MODE_VU) like MODE_PASST. v6: - reorder declarations, align summing, add curly brackets - rename tap_handler_all() to tap_handler() - rename packet_add_all_do() to tap_add_packet and remove func and line. - rename pool_flush_all() to tap_flush_pools() - rename tcp_fill_flag_header() to tcp_prepare_flags() - set optlen to 0 in tcp_prepare_flags() v5: - remove: [PATCH v4 01/10] tcp: inline tcp_l2_buf_fill_headers() - merge [PATCH v4 09/10] tcp: remove tap_hdr parameter into tcp: extract buffer management from tcp_send_flag() - update comments v4: - remove "tcp: extract buffer management from tcp_conn_tap_mss()" as the MSS size can be the same between socket and vhost-user. - rename tcp_send_flag() and tcp_data_from_sock() to tcp_buf_send_flag() and tcp_buf_data_from_sock() v3: - add 3 new patches tap: use in->buf_size rather than sizeof(pkt_buf) tcp: remove tap_hdr parameter iov: remove iov_copy() v2: - compare to MODE_PASTA in conf_open_files() too - move taph out of udp_update_hdr4()/udp_update_hdr6() Laurent Vivier (8): tcp: extract buffer management from tcp_send_flag() tcp: move buffers management functions to their own file tap: refactor packets handling functions udp: refactor UDP header update functions udp: rename udp_sock_handler() to udp_buf_sock_handler() vhost-user: compare mode MODE_PASTA and not MODE_PASST iov: remove iov_copy() tap: use in->buf_size rather than sizeof(pkt_buf) Makefile | 5 +- conf.c | 14 +- iov.c | 39 ---- iov.h | 3 - isolation.c | 10 +- passt.c | 4 +- tap.c | 134 +++++++----- tap.h | 3 + tcp.c | 580 ++++--------------------------------------------- tcp_buf.c | 513 +++++++++++++++++++++++++++++++++++++++++++ tcp_buf.h | 16 ++ tcp_internal.h | 96 ++++++++ udp.c | 68 +++--- udp.h | 2 +- 14 files changed, 799 insertions(+), 688 deletions(-) create mode 100644 tcp_buf.c create mode 100644 tcp_buf.h create mode 100644 tcp_internal.h -- 2.45.2

3 24

[PATCH v7 0/8] Add vhost-user support to passt (part 2)
by Laurent Vivier 13 Jun '24

13 Jun '24

Extract buffers management code from tcp.c and move it to tcp_buf.c tcp.c keeps all the generic code and will be also used by the vhost-user functions. Also compare mode to MODE_PASTA, as we will manage vhost-user mode (MODE_VU) like MODE_PASST. v7: - update comments (tap_flush_pools(), func and line) - drop "-L4" in tcp_buf.c header - fix *optlen initializatio - fix tcp4_flags_used/tcp6_flags_used value on error - fix seq_to_tap value v6: - reorder declarations, align summing, add curly brackets - rename tap_handler_all() to tap_handler() - rename packet_add_all_do() to tap_add_packet and remove func and line. - rename pool_flush_all() to tap_flush_pools() - rename tcp_fill_flag_header() to tcp_prepare_flags() - set optlen to 0 in tcp_prepare_flags() v5: - remove: [PATCH v4 01/10] tcp: inline tcp_l2_buf_fill_headers() - merge [PATCH v4 09/10] tcp: remove tap_hdr parameter into tcp: extract buffer management from tcp_send_flag() - update comments v4: - remove "tcp: extract buffer management from tcp_conn_tap_mss()" as the MSS size can be the same between socket and vhost-user. - rename tcp_send_flag() and tcp_data_from_sock() to tcp_buf_send_flag() and tcp_buf_data_from_sock() v3: - add 3 new patches tap: use in->buf_size rather than sizeof(pkt_buf) tcp: remove tap_hdr parameter iov: remove iov_copy() v2: - compare to MODE_PASTA in conf_open_files() too - move taph out of udp_update_hdr4()/udp_update_hdr6() Laurent Vivier (8): tcp: extract buffer management from tcp_send_flag() tcp: move buffers management functions to their own file tap: refactor packets handling functions udp: refactor UDP header update functions udp: rename udp_sock_handler() to udp_buf_sock_handler() vhost-user: compare mode MODE_PASTA and not MODE_PASST iov: remove iov_copy() tap: use in->buf_size rather than sizeof(pkt_buf) Makefile | 5 +- conf.c | 14 +- iov.c | 39 ---- iov.h | 3 - isolation.c | 10 +- passt.c | 4 +- tap.c | 132 ++++++----- tap.h | 3 + tcp.c | 580 ++++--------------------------------------------- tcp_buf.c | 519 +++++++++++++++++++++++++++++++++++++++++++ tcp_buf.h | 16 ++ tcp_internal.h | 96 ++++++++ udp.c | 68 +++--- udp.h | 2 +- 14 files changed, 803 insertions(+), 688 deletions(-) create mode 100644 tcp_buf.c create mode 100644 tcp_buf.h create mode 100644 tcp_internal.h -- 2.45.2

2 11

[PATCH v5 0/8] Add vhost-user support to passt (part 2)
by Laurent Vivier 12 Jun '24

12 Jun '24

Extract buffers management code from tcp.c and move it to tcp_buf.c tcp.c keeps all the generic code and will be also used by the vhost-user functions. Also compare mode to MODE_PASTA, as we will manage vhost-user mode (MODE_VU) like MODE_PASST. v5: - remove: [PATCH v4 01/10] tcp: inline tcp_l2_buf_fill_headers() - merge [PATCH v4 09/10] tcp: remove tap_hdr parameter into tcp: extract buffer management from tcp_send_flag() - update comments v4: - remove "tcp: extract buffer management from tcp_conn_tap_mss()" as the MSS size can be the same between socket and vhost-user. - rename tcp_send_flag() and tcp_data_from_sock() to tcp_buf_send_flag() and tcp_buf_data_from_sock() v3: - add 3 new patches tap: use in->buf_size rather than sizeof(pkt_buf) tcp: remove tap_hdr parameter iov: remove iov_copy() v2: - compare to MODE_PASTA in conf_open_files() too - move taph out of udp_update_hdr4()/udp_update_hdr6() Laurent Vivier (8): tcp: extract buffer management from tcp_send_flag() tcp: move buffers management functions to their own file tap: refactor packets handling functions udp: refactor UDP header update functions udp: rename udp_sock_handler() to udp_buf_sock_handler() vhost-user: compare mode MODE_PASTA and not MODE_PASST iov: remove iov_copy() tap: use in->buf_size rather than sizeof(pkt_buf) Makefile | 5 +- conf.c | 14 +- iov.c | 39 ---- iov.h | 3 - isolation.c | 10 +- passt.c | 4 +- tap.c | 135 ++++++------ tap.h | 7 + tcp.c | 554 +++---------------------------------------------- tcp_buf.c | 489 +++++++++++++++++++++++++++++++++++++++++++ tcp_buf.h | 16 ++ tcp_internal.h | 96 +++++++++ udp.c | 68 +++--- udp.h | 2 +- 14 files changed, 771 insertions(+), 671 deletions(-) create mode 100644 tcp_buf.c create mode 100644 tcp_buf.h create mode 100644 tcp_internal.h -- 2.44.0

3 25

[PATCH 0/9] Some more static checker fixes
by David Gibson 08 Jun '24

08 Jun '24

This series includes a number of fixes related to the static checkers: * Fedora 40 has updated to Cppcheck 2.14.1 which introduces some new warnings. Fix them. * Jon's recent patch caused a small cppcheck regression. I assume neither Jon nor Stefano is using sufficiently recent cppcheck versions to catch it. Fix that too. * We were disabling the bugprone-macro parentheses check in clang-tidy. I don't think that's a good idea. Re-enable it and fix existing warnings. * It might also be a good idea to enable the bugprone-narrowing-conversions check. Fix a number of issues across the tree which, amongst other things trigger that warning. There are lots of other places that trigger the warning which I haven't fixed yet, so don't enable it yet. David Gibson (9): tcp: Make pointer const in tcp_revert_seq udp: Make rport calculation more local cppcheck: Suppress constParameterCallback errors Remove pointless macro parameters in CALL_PROTO_HANDLER clang-tidy: Enable the bugprone-macro-parentheses check util: Use unsigned indices for bits in bitmaps conf: Safer parsing of MAC addresses lineread: Use ssize_t for line lengths util: Use 'long' to represent millisecond durations Makefile | 3 +-- conf.c | 55 +++++++++++++++++++++++++++++++++++----------------- lineread.c | 10 ++++------ lineread.h | 7 ++++--- passt.c | 6 +++--- tap.c | 37 ++++++++++++++++++----------------- tcp.c | 10 +++++----- tcp_splice.c | 4 ++-- udp.c | 3 +-- util.c | 10 +++++----- util.h | 8 ++++---- 11 files changed, 85 insertions(+), 68 deletions(-) -- 2.45.2

2 12

[PATCH v2 0/1] Some more static checker fixes
by David Gibson 08 Jun '24

08 Jun '24

This series includes a number of fixes related to the static checkers: * Fedora 40 has updated to Cppcheck 2.14.1 which introduces some new warnings. Fix them. * Jon's recent patch caused a small cppcheck regression. I assume neither Jon nor Stefano is using sufficiently recent cppcheck versions to catch it. Fix that too. * We were disabling the bugprone-macro parentheses check in clang-tidy. I don't think that's a good idea. Re-enable it and fix existing warnings. * It might also be a good idea to enable the bugprone-narrowing-conversions check. Fix a number of issues across the tree which, amongst other things trigger that warning. There are lots of other places that trigger the warning which I haven't fixed yet, so don't enable it yet. Changes since v2: * Rebased after most of the series was applied * Avoid triggering unmatchedSuppression on earlier cppcheck versions David Gibson (1): cppcheck: Suppress constParameterCallback errors pasta.c | 1 + tcp.c | 1 + tcp_splice.c | 1 + 3 files changed, 3 insertions(+) -- 2.45.2

1 1

passt: new version 2024_06_07.8a83b53 available
by Stefano Brivio 07 Jun '24

07 Jun '24

The new version with tag 2024_06_07.8a83b53 includes the following changes: 8a83b53 selinux: Allow access to user_devpts ec416fd tcp, flow: Fix some error paths which didn't clean up flows properly 3f63743 util: Use 'long' to represent millisecond durations f9e8ee0 lineread: Use ssize_t for line lengths c919bbb conf: Safer parsing of MAC addresses bda80ef util: Use unsigned indices for bits in bitmaps 0e36fe1 clang-tidy: Enable the bugprone-macro-parentheses check 7094b91 Remove pointless macro parameters in CALL_PROTO_HANDLER c80fa6a udp: Make rport calculation more local d2afb4b tcp: Make pointer const in tcp_revert_seq b3aeb00 log: Remove log_to_stdout option 7cb2088 conf: Don't print usage via the logging subsystem e651197 conf: Remove unhelpful usage() wrapper e84a01e tcp: move seq_to_tap update to when frame is queued https://passt.top/passt/log/?qt=range&q=2024_05_23.765eb0b..2024_06_07.8a83… Packages: - Alpine Linux: https://pkgs.alpinelinux.org/packages?name=passt - Arch Linux: https://www.archlinux.org/packages/extra/x86_64/passt/ https://archlinuxarm.org/packages/aarch64/passt https://archlinuxarm.org/packages/armv7h/passt - Chimera: https://pkgs.chimera-linux.org/packages?name=passt - Debian tracker: https://tracker.debian.org/pkg/passt - Copr (CentOS Stream, EPEL, Fedora, Mageia): https://copr.fedorainfracloud.org/coprs/sbrivio/passt/build/7558696/ permanent mirror: https://passt.top/builds/copr/0^20240607.g8a83b53/ - Fedora updates: https://bodhi.fedoraproject.org/updates/?packages=passt - Gentoo versions: https://packages.gentoo.org/packages/net-misc/passt - GNU Guix: https://packages.guix.gnu.org/packages/passt/ - openSUSE: https://software.opensuse.org/package/passt - PLD Linux: https://git.pld-linux.org/cgi-bin/gitweb.cgi?p=packages/passt.git - Solus: https://github.com/getsolus/packages/tree/main/packages/p/passt - Ubuntu tracker: https://launchpad.net/ubuntu/+source/passt - Void Linux: https://voidlinux.org/packages/?q=passt - Static builds: - Package for other RPM-based distributions, x86_64 only: https://passt.top/builds/latest/x86_64/passt-g1eddc56-1.x86_64.rpm - x86_64 static binaries: https://passt.top/builds/latest/x86_64/ - Debian package, from x86_64 static build: https://passt.top/builds/latest/x86_64/passt_1eddc56-1_all.deb -- Stefano

1 0

[PATCH] tcp, flow: Fix some error paths which didn't clean up flows properly
by David Gibson 07 Jun '24

07 Jun '24

Flow table entries need to be fully initialised before returning to the main epoll loop. Commit 0060acd1 ("flow: Clarify and enforce flow state transitions") now enforces that: once a flow is allocated we must either cancel it, or activate it before returning to the main loop, or we will hit an ASSERT(). Some error paths in tcp_conn_from_tap() weren't correctly updated for this requirement - we can exit with a flow entry incompletely initialised. Correct that by cancelling the flows in those situations. I don't have enough information to be certain if this is the cause for podman bug 22925, but it plausibly could be. Fixes: 0060acd1 ("flow: Clarify and enforce flow state transitions") Link: https://github.com/containers/podman/issues/22925 Signed-off-by: David Gibson <david(a)gibson.dropbear.id.au> --- tcp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tcp.c b/tcp.c index 0dccde9c..cb613cf3 100644 --- a/tcp.c +++ b/tcp.c @@ -2067,7 +2067,7 @@ static void tcp_conn_from_tap(struct ctx *c, sa_family_t af, if (!bind(s, sa, sl)) { tcp_rst(c, conn); /* Nobody is listening then */ - return; + goto cancel; } if (errno != EADDRNOTAVAIL && errno != EACCES) conn_flag(c, conn, LOCAL); @@ -2080,7 +2080,7 @@ static void tcp_conn_from_tap(struct ctx *c, sa_family_t af, if (connect(s, sa, sl)) { if (errno != EINPROGRESS) { tcp_rst(c, conn); - return; + goto cancel; } tcp_get_sndbuf(conn); @@ -2088,7 +2088,7 @@ static void tcp_conn_from_tap(struct ctx *c, sa_family_t af, tcp_get_sndbuf(conn); if (tcp_send_flag(c, conn, SYN | ACK)) - return; + goto cancel; conn_event(c, conn, TAP_SYN_ACK_SENT); } -- 2.45.2

2 1

[PATCH] selinux: Allow access to user_devpts
by Derek Schrock 07 Jun '24

07 Jun '24

Allow access to user_devpts. $ pasta --version pasta 0^20240510.g7288448-1.fc40.x86_64 ... $ awk '' < /dev/null $ pasta --version $ While this might be a awk bug it appears pasta should still have access to devpts. --- contrib/selinux/pasta.te | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/selinux/pasta.te b/contrib/selinux/pasta.te index 0ceda06..4e36c3f 100644 --- a/contrib/selinux/pasta.te +++ b/contrib/selinux/pasta.te @@ -211,3 +211,4 @@ allow pasta_t ifconfig_t:process { noatsecure rlimitinh siginh }; allow pasta_t netutils_t:process { noatsecure rlimitinh siginh }; allow pasta_t ping_t:process { noatsecure rlimitinh siginh }; allow pasta_t user_tty_device_t:chr_file { append read write }; +allow pasta_t user_devpts_t:chr_file { append read write }; -- 2.45.0

3 7

[PATCH v6] tcp: Make pointer const in tcp_revert_seq
by David Gibson 06 Jun '24

06 Jun '24

The th pointer could be const, which causes a cppcheck warning on at least some cppcheck versions (e.g. Cppcheck 2.13.0 in Fedora 40). Fixes: e84a01e94 "tcp: move seq_to_tap update to when frame is queued" Signed-off-by: David Gibson <david(a)gibson.dropbear.id.au> --- tcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcp.c b/tcp.c index 89a5b19a..ff1198dd 100644 --- a/tcp.c +++ b/tcp.c @@ -1261,8 +1261,8 @@ static void tcp_revert_seq(struct tcp_tap_conn **conns, struct iovec (*frames)[T int i; for (i = 0; i < num_frames; i++) { + const struct tcphdr *th = frames[i][TCP_IOV_PAYLOAD].iov_base; struct tcp_tap_conn *conn = conns[i]; - struct tcphdr *th = frames[i][TCP_IOV_PAYLOAD].iov_base; uint32_t seq = ntohl(th->seq); if (SEQ_LE(conn->seq_to_tap, seq)) -- 2.45.2

1 1

2024

2023

2022

2021

dev