- dev - passt

[PATCH 0/5] Improvements to "connection" tracking for UDP
by David Gibson 18 May '23

18 May '23

We need rudimentary "connection" tracking for UDP because we do have a many-to-one mapping for our few NAT cases. This is handled by the port flags. We can make some simplfiications to this code for clarity. David Gibson (5): udp: Don't attempt to translate a 0.0.0.0 source address udp: Small streamline to udp_update_hdr4() udp: Implement IPv6 PORT_GUA logic for IPv4 as well udp: Clarify connection tracking flags udp: Remove PORT_ADDR_SEEN "connection" tracking mode udp.c | 69 +++++++++++++++++++++++++++++++---------------------------- 1 file changed, 36 insertions(+), 33 deletions(-) -- 2.40.1

1 6

[PATCH 00/10] RFC/RFT: Optionally copy all routes and addresses for pasta, allow gateway-less routes
by Stefano Brivio 18 May '23

18 May '23

This series, along with pseudo-related fixes, enables: - optional copy of all routes from selected interface in outer namespace, to (hopefully!) fix the issue reported by Callum at: https://github.com/containers/podman/issues/18539 - optional copy of all addresses, mostly for consistency. It doesn't, however, enable assignment of multiple addresses in the sense requested at: https://bugs.passt.top/show_bug.cgi?id=47 because the addresses still need to be present on the host, and the "outer" address isn't selected depending on the address used inside the container - operation without a gateway address, to (again, hopefully) support usage of Wireguard endpoints established outside the container, https://bugs.passt.top/show_bug.cgi?id=49 I tested the single functionalities introduced here, but I didn't try to reproduce the setups where the issues were reported, so some help with testing is definitely fundamental here. Thanks. Stefano Brivio (10): netlink: Fix comment about response buffer size for nl_req() pasta: Improve error handling on failure to join network namespace netlink: Add functionality to copy routes from outer namespace conf: --config-net option is for pasta mode only conf, pasta: With --config-net, copy all routes by default Revert "conf: Adjust netmask on mismatch between IPv4 address/netmask and gateway" conf: Don't exit if sourced default route has no gateway netlink: Add functionality to copy addresses from outer namespace conf, pasta: With --config-net, copy all addresses by default passt.h: Fix description of pasta_ifi in struct ctx conf.c | 81 ++++++++++++++++++++--------------- netlink.c | 123 +++++++++++++++++++++++++++++++++++++++--------------- netlink.h | 13 ++++-- passt.1 | 25 ++++++++++- passt.h | 8 +++- pasta.c | 26 ++++++++---- 6 files changed, 195 insertions(+), 81 deletions(-) -- 2.39.2

2 20

[PATCH] tap: Don't update ip6.addr_seen to ::
by David Gibson 17 May '23

17 May '23

When we receive packets from the tap side, we update the addr_seen fields to reflect the last known address of the guest or ns. For ip4.addr_seen we, sensibly, only update if the address we've just seen isn't 0 (0.0.0.0). This case can occur during early DHCP transactions. We have no equivalent case for IPv6. We're less likely to hit this, because DHCPv6 uses link-local addresses, however we can see an source address of :: with certain multicast operations. This can bite us if we try to make an incoming connection very early after starting pasta with --config-net: we may have only seen some of those multicast packets, updated addr_seen to :: and not had any "real" packets to update it to a global address. I've seen this with some of the avocado test conversions. In any case, it can never make sense to update addr_seen to ::, so explicitly exclude that case. Signed-off-by: David Gibson <david(a)gibson.dropbear.id.au> --- tap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tap.c b/tap.c index faa4e26..c0b7f33 100644 --- a/tap.c +++ b/tap.c @@ -739,7 +739,7 @@ resume: if (IN6_IS_ADDR_UNSPECIFIED(&c->ip6.addr_seen)) { c->ip6.addr_seen = *saddr; } - } else { + } else if (!IN6_IS_ADDR_UNSPECIFIED(saddr)){ c->ip6.addr_seen = *saddr; } -- 2.40.1

2 1

[PATCH v2 00/21] RFCv2: Proof-of-concept conversion of some tests to Avocado framework
by David Gibson 16 May '23

16 May '23

As discussed on calls, I've been investigating Avocado as a possible replacement for our hand-rolled shell test framework. This is a second draft proof-of-concept conversion of a few of the tests to the Avocado framework. Specifically, the static checkers, the build tests and the pasta transfer tests are converted. In this second version, I've done a lot of rework (maybe too much) on the helper library. It's got a lot more capabilities and is more consistent. The new tests will get failures if you don't also apply the fix I send recently to prevent updating ip6.addr_seen to ::. Promising things: * I remain happy with the speed improvement (under half the time of the equivalent old tests) * The fact that it's no longer dependent on the host network is great * I'm cautiously optimistic about the helper library making it relatively easy to add a bunch more tests with further coverage Concerning things: * I'm coming to hate OO and jUnit patterns more and more, these can make it pretty non-obvious what each test relies on in terms of setup Changes since RFCv1: * Sweeping rework of the test library * Started using tags to split between the "real" tests (run with "make avocado") and "meta" tests (run with "make avocado-meta"). The latter are tests for the test infrastructure and helpers themselves, rather than testing anything in passt or pasta David Gibson (21): test/nstool: Provide useful error if given a path that's too long test/nstool: Fix fd leak in accept() loop avocado: Make a duplicate copy of testsuite for comparison purposes avocado: Don't double download assets for test/ and oldtest/ avocado: Move static checkers to avocado avocado/tasst: Helper functions for executing commands in different places avocado: Convert build tests to avocado avocado/tasst: Add helpers for running background commands on sites avocado/tasst: Add helper to get network interface names for a site avocado/tasst: Add helpers to run commands with nstool avocado/tasst: Add ifup and network address helpers to Site avocado/tasst: Helper for creating veth devices between namespaces avocado/tasst: Add helper for getting MTU of a network interface avocado/tasst: Add helper to wait for IP address to appear avocado/tasst: Add helpers for getting a site's routes avocado/tasst: Helpers for test transferring data between sites avocado/tasst: IP address allocation helpers avocado/tasst: Helpers for testing NDP behaviour avocado/tasst: Helpers for testing DHCP & DHCPv6 behaviour avocado/tasst: Helpers to construct a simple network environment for tests avocado: Convert basic pasta tests Makefile | 19 + avocado/.gitignore | 1 + avocado/build.py | 75 +++ avocado/pasta.py | 183 ++++++ avocado/static_checkers/clang-tidy.sh | 3 + avocado/static_checkers/cppcheck.sh | 3 + avocado/tasst/__init__.py | 32 + avocado/tasst/address.py | 89 +++ avocado/tasst/dhcp.py | 133 +++++ avocado/tasst/dhcpv6.py | 123 ++++ avocado/tasst/meta/__init__.py | 16 + avocado/tasst/meta/static_ifup.py | 60 ++ avocado/tasst/meta/veth.py | 95 +++ avocado/tasst/ndp.py | 129 ++++ avocado/tasst/nstool.py | 214 +++++++ avocado/tasst/scenario/__init__.py | 11 + avocado/tasst/scenario/simple.py | 96 +++ avocado/tasst/site.py | 207 +++++++ avocado/tasst/transfer.py | 228 +++++++ oldtest/.gitignore | 11 + oldtest/Makefile | 119 ++++ oldtest/README.md | 137 +++++ {test => oldtest}/build/all | 0 {test => oldtest}/build/clang_tidy | 0 {test => oldtest}/build/cppcheck | 0 oldtest/ci | 1 + oldtest/demo/passt | 245 ++++++++ oldtest/demo/pasta | 274 +++++++++ oldtest/demo/podman | 819 ++++++++++++++++++++++++++ oldtest/distro/debian | 252 ++++++++ oldtest/distro/fedora | 396 +++++++++++++ oldtest/distro/opensuse | 208 +++++++ oldtest/distro/ubuntu | 216 +++++++ oldtest/env/mate-terminal.profile | 42 ++ oldtest/find-arm64-firmware.sh | 13 + oldtest/lib/context | 130 ++++ oldtest/lib/layout | 259 ++++++++ oldtest/lib/layout_ugly | 113 ++++ oldtest/lib/perf_report | 272 +++++++++ oldtest/lib/setup | 385 ++++++++++++ oldtest/lib/setup_ugly | 58 ++ oldtest/lib/term | 750 +++++++++++++++++++++++ oldtest/lib/test | 398 +++++++++++++ oldtest/lib/util | 133 +++++ oldtest/lib/video | 152 +++++ oldtest/memory/passt | 187 ++++++ oldtest/nstool.c | 565 ++++++++++++++++++ oldtest/passt.mbuto | 83 +++ oldtest/passt.mem.mbuto | 44 ++ oldtest/passt/dhcp | 70 +++ oldtest/passt/ndp | 33 ++ oldtest/passt/shutdown | 19 + oldtest/passt/tcp | 76 +++ oldtest/passt/udp | 46 ++ oldtest/passt_in_ns/icmp | 32 + oldtest/passt_in_ns/shutdown | 19 + oldtest/passt_in_ns/tcp | 256 ++++++++ oldtest/passt_in_ns/udp | 138 +++++ {test => oldtest}/pasta/dhcp | 0 {test => oldtest}/pasta/ndp | 0 {test => oldtest}/pasta/tcp | 0 {test => oldtest}/pasta/udp | 0 oldtest/pasta_options/log_to_file | 93 +++ oldtest/perf/passt_tcp | 215 +++++++ oldtest/perf/passt_udp | 165 ++++++ oldtest/perf/pasta_tcp | 300 ++++++++++ oldtest/perf/pasta_udp | 219 +++++++ oldtest/prepare-distro-img.sh | 18 + oldtest/run | 238 ++++++++ oldtest/run_demo | 1 + oldtest/two_guests/basic | 80 +++ oldtest/valgrind.supp | 9 + test/lib/layout | 31 - test/lib/setup | 47 -- test/nstool.c | 24 +- test/run | 14 - 76 files changed, 10022 insertions(+), 100 deletions(-) create mode 100644 avocado/.gitignore create mode 100644 avocado/build.py create mode 100644 avocado/pasta.py create mode 100755 avocado/static_checkers/clang-tidy.sh create mode 100755 avocado/static_checkers/cppcheck.sh create mode 100644 avocado/tasst/__init__.py create mode 100644 avocado/tasst/address.py create mode 100644 avocado/tasst/dhcp.py create mode 100644 avocado/tasst/dhcpv6.py create mode 100644 avocado/tasst/meta/__init__.py create mode 100644 avocado/tasst/meta/static_ifup.py create mode 100644 avocado/tasst/meta/veth.py create mode 100644 avocado/tasst/ndp.py create mode 100644 avocado/tasst/nstool.py create mode 100644 avocado/tasst/scenario/__init__.py create mode 100644 avocado/tasst/scenario/simple.py create mode 100644 avocado/tasst/site.py create mode 100644 avocado/tasst/transfer.py create mode 100644 oldtest/.gitignore create mode 100644 oldtest/Makefile create mode 100644 oldtest/README.md rename {test => oldtest}/build/all (100%) rename {test => oldtest}/build/clang_tidy (100%) rename {test => oldtest}/build/cppcheck (100%) create mode 120000 oldtest/ci create mode 100644 oldtest/demo/passt create mode 100644 oldtest/demo/pasta create mode 100644 oldtest/demo/podman create mode 100644 oldtest/distro/debian create mode 100644 oldtest/distro/fedora create mode 100644 oldtest/distro/opensuse create mode 100644 oldtest/distro/ubuntu create mode 100644 oldtest/env/mate-terminal.profile create mode 100755 oldtest/find-arm64-firmware.sh create mode 100644 oldtest/lib/context create mode 100644 oldtest/lib/layout create mode 100644 oldtest/lib/layout_ugly create mode 100755 oldtest/lib/perf_report create mode 100755 oldtest/lib/setup create mode 100755 oldtest/lib/setup_ugly create mode 100755 oldtest/lib/term create mode 100755 oldtest/lib/test create mode 100755 oldtest/lib/util create mode 100755 oldtest/lib/video create mode 100644 oldtest/memory/passt create mode 100644 oldtest/nstool.c create mode 100755 oldtest/passt.mbuto create mode 100755 oldtest/passt.mem.mbuto create mode 100644 oldtest/passt/dhcp create mode 100644 oldtest/passt/ndp create mode 100644 oldtest/passt/shutdown create mode 100644 oldtest/passt/tcp create mode 100644 oldtest/passt/udp create mode 100644 oldtest/passt_in_ns/icmp create mode 100644 oldtest/passt_in_ns/shutdown create mode 100644 oldtest/passt_in_ns/tcp create mode 100644 oldtest/passt_in_ns/udp rename {test => oldtest}/pasta/dhcp (100%) rename {test => oldtest}/pasta/ndp (100%) rename {test => oldtest}/pasta/tcp (100%) rename {test => oldtest}/pasta/udp (100%) create mode 100644 oldtest/pasta_options/log_to_file create mode 100644 oldtest/perf/passt_tcp create mode 100644 oldtest/perf/passt_udp create mode 100644 oldtest/perf/pasta_tcp create mode 100644 oldtest/perf/pasta_udp create mode 100755 oldtest/prepare-distro-img.sh create mode 100755 oldtest/run create mode 120000 oldtest/run_demo create mode 100644 oldtest/two_guests/basic create mode 100644 oldtest/valgrind.supp -- 2.40.1

1 21

[PATCH] correct -6 option in manpage
by lemmi 10 May '23

10 May '23

Signed-off-by: lemmi <lemmi(a)nerd2nerd.org> --- passt.1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/passt.1 b/passt.1 index 9c4da20..19e01d5 100644 --- a/passt.1 +++ b/passt.1 @@ -310,7 +310,7 @@ By default, IPv6 operation is enabled as long as at least an IPv6 default route and an interface address are configured on a given host interface. .TP -.BR \-4 ", " \-\-ipv6-only +.BR \-6 ", " \-\-ipv6-only Enable IPv6-only operation. IPv4 traffic will be ignored. By default, IPv4 operation is enabled as long as at least an IPv4 default route and an interface address are configured on a given host interface. -- 2.40.1

3 2

passt: new version 2023_05_09.96f8d55 available
by Stefano Brivio 10 May '23

10 May '23

The new version with tag 2023_05_09.96f8d55 includes the following changes: 96f8d55 correct -6 option in manpage 940bd3e passt: Fix error check for signal(), improve error messages 1a3ade9 nstool: Enter holder's cwd when changing mount ns with nstool exec 98031be nstool: Advertise the holder's cwd (in its mountns) across the socket 469b69a test: Use "nstool exec" to slightly simplify tests 3372cd0 test: Initialise ${TRACE} properly 329149d nstool: Add --keep-caps option to nstool exec 0b66944 nstool: Add nstool exec command to execute commands in an nstool namespace 3bcbca5 nstool: Helpers to iterate through namespace types f6a9ea3 nstool: Add magic number to advertized information 4311066 nstool: Detect what namespaces target is in fd4a752 nstool: Replace "pid" subcommand with "info" subcommand a4b017d nstool: Split some command line parsing and socket setup to subcommands 42fb218 nstool: Move description of its operation modes from comment to usage 2884ccd nstool: Reverse parameters to nstool 4914fce nstool: Rename nsholder to nstool 55bbe3d test: Remove race between commands run in the same context ca2749e passt: Relicense to GPL 2.0, or any later version https://passt.top/passt/log/?qt=range&q=2023_03_29.b10b983..2023_05_09.96f8… Note that this is the first GPLv2+ version of passt, changing from AGPLv3+. Packages: - Arch Linux AUR: https://aur.archlinux.org/packages/passt - Debian tracker: https://tracker.debian.org/pkg/passt - Copr (CentOS Stream, EPEL, Fedora, Mageia, openSUSE): https://copr.fedorainfracloud.org/coprs/sbrivio/passt/build/5906538/ permanent mirror: https://passt.top/builds/copr/0^20230509.g96f8d55/ - Fedora updates: https://bodhi.fedoraproject.org/updates/?packages=passt - Ubuntu tracker: https://packages.ubuntu.com/lunar/passt - Void Linux: https://voidlinux.org/packages/?q=passt - Static builds: - Package for other RPM-based distributions, x86_64 only: https://passt.top/builds/latest/x86_64/passt-g96f8d55-1.x86_64.rpm - x86_64 static binaries: https://passt.top/builds/latest/x86_64/ - Debian package, from x86_64 static build: https://passt.top/builds/latest/x86_64/passt_96f8d55-1_all.deb -- Stefano

1 0

[PATCH 0/7] RFC: Allow NAT-to-host address to be configured explicitly
by David Gibson 04 May '23

04 May '23

Since the passt/pasta guest and host (usually) have the same address, it's not possible for the guest to address the host, which is a serious limitation. So, passt/pasta NATs the address of the default gateway to the host as a special case. That can be quite limiting however. Most obviously this prevents the guest from addressing the gateway, which is less common than needing to address the host, but certainly possible. The combination of the concepts of "gateway" and "nat to host" address makes for some extra confusion as well. This series separates the two concepts in both the code and the tests, and adds a command line option for configuring the NAT to host address explicitly (by default it remains the same as the gateway). This isn't quite ready for merge yet. First, I think there might be a bug I haven't managed to track down yet which causes intermittent failures in some of the UDP throughput tests. Second, I don't think we want to commit to this command line option just yet, without a look at what further NAT cleanups we might want to do (which I'll be looking at in the near term future). David Gibson (7): udp: Simplify setting of source IPv6 address for inbound packets udp: Simplify setting od destination IPv6 address for inbound packets nat: Split notion of gateway/router from from guest-visible host address nat: Simplify --no-map-gw handling nat: Centralise handling of gateway versus link-local address for host NAT Allow nat-to-host addresses to be overridden nat, test: Test --nat-to-host option conf.c | 113 ++++++++++++++++++++++++++++++------------ dhcp.c | 14 +++--- dhcpv6.c | 4 +- ndp.c | 4 +- passt.h | 14 +++--- pasta.c | 4 +- tcp.c | 17 +++---- test/lib/setup | 19 +++++-- test/lib/test | 12 +++++ test/passt/dhcp | 7 ++- test/passt/tcp | 10 ++-- test/passt/udp | 5 +- test/passt_in_ns/dhcp | 73 +++++++++++++++++++++++++++ test/passt_in_ns/tcp | 28 +++++------ test/passt_in_ns/udp | 14 +++--- test/pasta/tcp | 11 ++-- test/pasta/udp | 6 +-- test/perf/passt_tcp | 30 ++++++----- test/perf/passt_udp | 26 +++++----- test/perf/pasta_tcp | 26 +++++----- test/perf/pasta_udp | 22 ++++---- test/run | 4 +- test/two_guests/basic | 10 ++-- udp.c | 41 ++++++--------- 24 files changed, 313 insertions(+), 201 deletions(-) create mode 100644 test/passt_in_ns/dhcp -- 2.40.1

2 9

[PATCH 0/7] RFC: Proof-of-concept conversion of some tests to Avocado framework
by David Gibson 20 Apr '23

20 Apr '23

As discussed on calls, I've been investigating Avocado as a possible replacement for our hand-rolled shell test framework. This is a proof-of-concept conversion of a few of the tests to the Avocado framework. Specifically, the static checkers, the build tests and the pasta transfer tests are converted. I think it's a promising start. On my laptop running the Avocado suite takes less than half the time of the equivalent tests in the old framework (1m10 vs 2m30), despite the fact that the avocado tests are reconstructing their test environment for every single test. There's also a handful of additional tests in Avocado (mostly for the test mechanics themselves). David Gibson (7): avocado: Make a duplicate copy of testsuite for comparison purposes avocado: Don't double download assets for test/ and oldtest/ avocado: Move static checkers to avocado avocado: Convert build tests to avocado avocado: Helper functions and classes to run commands via nstool avocado: Helper to get link-local address and wait for SLAAC to complete avocado: Convert pasta transfer tests to Avocado Makefile | 11 + avocado/.gitignore | 1 + avocado/build.py | 83 +++ avocado/common.py | 213 +++++++ avocado/pasta.py | 196 ++++++ avocado/pasta_dhcp.py | 95 +++ avocado/pasta_ndp.py | 52 ++ avocado/pasta_tcp.py | 61 ++ avocado/pasta_udp.py | 55 ++ avocado/static_checkers/clang-tidy.sh | 3 + avocado/static_checkers/cppcheck.sh | 3 + oldtest/.gitignore | 11 + oldtest/Makefile | 119 ++++ oldtest/README.md | 137 +++++ {test => oldtest}/build/all | 0 {test => oldtest}/build/clang_tidy | 0 {test => oldtest}/build/cppcheck | 0 oldtest/ci | 1 + oldtest/demo/passt | 245 ++++++++ oldtest/demo/pasta | 274 +++++++++ oldtest/demo/podman | 819 ++++++++++++++++++++++++++ oldtest/distro/debian | 252 ++++++++ oldtest/distro/fedora | 396 +++++++++++++ oldtest/distro/opensuse | 208 +++++++ oldtest/distro/ubuntu | 216 +++++++ oldtest/env/mate-terminal.profile | 42 ++ oldtest/find-arm64-firmware.sh | 13 + oldtest/lib/context | 130 ++++ oldtest/lib/layout | 259 ++++++++ oldtest/lib/layout_ugly | 113 ++++ oldtest/lib/perf_report | 272 +++++++++ oldtest/lib/setup | 385 ++++++++++++ oldtest/lib/setup_ugly | 58 ++ oldtest/lib/term | 750 +++++++++++++++++++++++ oldtest/lib/test | 398 +++++++++++++ oldtest/lib/util | 133 +++++ oldtest/lib/video | 152 +++++ oldtest/memory/passt | 187 ++++++ oldtest/nstool.c | 565 ++++++++++++++++++ oldtest/passt.mbuto | 83 +++ oldtest/passt.mem.mbuto | 44 ++ oldtest/passt/dhcp | 70 +++ oldtest/passt/ndp | 33 ++ oldtest/passt/shutdown | 19 + oldtest/passt/tcp | 76 +++ oldtest/passt/udp | 46 ++ oldtest/passt_in_ns/icmp | 32 + oldtest/passt_in_ns/shutdown | 19 + oldtest/passt_in_ns/tcp | 256 ++++++++ oldtest/passt_in_ns/udp | 138 +++++ {test => oldtest}/pasta/dhcp | 0 {test => oldtest}/pasta/ndp | 0 {test => oldtest}/pasta/tcp | 0 {test => oldtest}/pasta/udp | 0 oldtest/pasta_options/log_to_file | 93 +++ oldtest/perf/passt_tcp | 215 +++++++ oldtest/perf/passt_udp | 165 ++++++ oldtest/perf/pasta_tcp | 300 ++++++++++ oldtest/perf/pasta_udp | 219 +++++++ oldtest/prepare-distro-img.sh | 18 + oldtest/run | 238 ++++++++ oldtest/run_demo | 1 + oldtest/two_guests/basic | 80 +++ oldtest/valgrind.supp | 9 + test/lib/layout | 31 - test/lib/setup | 37 -- test/run | 14 - 67 files changed, 9062 insertions(+), 82 deletions(-) create mode 100644 avocado/.gitignore create mode 100644 avocado/build.py create mode 100644 avocado/common.py create mode 100644 avocado/pasta.py create mode 100644 avocado/pasta_dhcp.py create mode 100644 avocado/pasta_ndp.py create mode 100644 avocado/pasta_tcp.py create mode 100644 avocado/pasta_udp.py create mode 100755 avocado/static_checkers/clang-tidy.sh create mode 100755 avocado/static_checkers/cppcheck.sh create mode 100644 oldtest/.gitignore create mode 100644 oldtest/Makefile create mode 100644 oldtest/README.md rename {test => oldtest}/build/all (100%) rename {test => oldtest}/build/clang_tidy (100%) rename {test => oldtest}/build/cppcheck (100%) create mode 120000 oldtest/ci create mode 100644 oldtest/demo/passt create mode 100644 oldtest/demo/pasta create mode 100644 oldtest/demo/podman create mode 100644 oldtest/distro/debian create mode 100644 oldtest/distro/fedora create mode 100644 oldtest/distro/opensuse create mode 100644 oldtest/distro/ubuntu create mode 100644 oldtest/env/mate-terminal.profile create mode 100755 oldtest/find-arm64-firmware.sh create mode 100644 oldtest/lib/context create mode 100644 oldtest/lib/layout create mode 100644 oldtest/lib/layout_ugly create mode 100755 oldtest/lib/perf_report create mode 100755 oldtest/lib/setup create mode 100755 oldtest/lib/setup_ugly create mode 100755 oldtest/lib/term create mode 100755 oldtest/lib/test create mode 100755 oldtest/lib/util create mode 100755 oldtest/lib/video create mode 100644 oldtest/memory/passt create mode 100644 oldtest/nstool.c create mode 100755 oldtest/passt.mbuto create mode 100755 oldtest/passt.mem.mbuto create mode 100644 oldtest/passt/dhcp create mode 100644 oldtest/passt/ndp create mode 100644 oldtest/passt/shutdown create mode 100644 oldtest/passt/tcp create mode 100644 oldtest/passt/udp create mode 100644 oldtest/passt_in_ns/icmp create mode 100644 oldtest/passt_in_ns/shutdown create mode 100644 oldtest/passt_in_ns/tcp create mode 100644 oldtest/passt_in_ns/udp rename {test => oldtest}/pasta/dhcp (100%) rename {test => oldtest}/pasta/ndp (100%) rename {test => oldtest}/pasta/tcp (100%) rename {test => oldtest}/pasta/udp (100%) create mode 100644 oldtest/pasta_options/log_to_file create mode 100644 oldtest/perf/passt_tcp create mode 100644 oldtest/perf/passt_udp create mode 100644 oldtest/perf/pasta_tcp create mode 100644 oldtest/perf/pasta_udp create mode 100755 oldtest/prepare-distro-img.sh create mode 100755 oldtest/run create mode 120000 oldtest/run_demo create mode 100644 oldtest/two_guests/basic create mode 100644 oldtest/valgrind.supp -- 2.40.0

1 7

passt.c: incorrect signal() return value check
by Valtteri Vuorikoski 13 Apr '23

13 Apr '23

In current master, passt.c:main() has an incorrect check on signal() return value: if (sigaction(SIGCHLD, &sa, NULL) || signal(SIGPIPE, SIG_IGN)) die("Couldn't install signal handlers"); signal() returns SIG_ERR on failure or the previous setting if present. If a setting has been inherited from the parent (as is the case when starting from systemd with the default setting of IgnoreSIGPIPE=yes), the check will fail. The if statement should check for SIG_ERR for the SIGPIPE case, or alternatively switch to sigaction() since that's used for everything else in the code. -Valtteri (please cc on replies)

2 3

[PATCH] passt: Fix error check for signal(), improve error messages
by Stefano Brivio 13 Apr '23

13 Apr '23

Valtteri reports that if SIGPIPE already has a disposition set by the parent process, such as systemd with the default setting of IgnoreSIGPIPE=yes, signal() will return the previous value, not zero, and this is not an error: check for SIG_ERR instead. While at it, split messages for failures of sigaction() and signal(), and report the actual error. Reported-by: Valtteri Vuorikoski <vuori(a)notcom.org> Fixes: 8534be076c73 ("Catch failures when installing signal handlers") Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com> --- passt.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/passt.c b/passt.c index 7fa1170..3b9b36b 100644 --- a/passt.c +++ b/passt.c @@ -204,8 +204,15 @@ int main(int argc, char **argv) name = basename(argv0); if (strstr(name, "pasta")) { sa.sa_handler = pasta_child_handler; - if (sigaction(SIGCHLD, &sa, NULL) || signal(SIGPIPE, SIG_IGN)) - die("Couldn't install signal handlers"); + if (sigaction(SIGCHLD, &sa, NULL)) { + die("Couldn't install signal handlers: %s", + strerror(errno)); + } + + if (signal(SIGPIPE, SIG_IGN) == SIG_ERR) { + die("Couldn't set disposition for SIGPIPE: %s", + strerror(errno)); + } c.mode = MODE_PASTA; log_name = "pasta"; -- 2.39.2

1 0