- dev - passt

Fix nullptr deref
by Boleyn Su 09 Sep '25

09 Sep '25

Hi passt-dev, Please find the attached patch. Regards, Boleyn -- Boleyn Su (simplified Chinese: 苏蕉; traditional Chinese: 蘇蕉; Pinyin: Sū Jiāo; Katakana: スージャオ) My PGP public key is available at boleyn.su/pgp.

2 2

[PATCH] test: Remove unused distro images
by Yumei Huang 08 Sep '25

08 Sep '25

Some of the download links are broken, and none of the images are used in current tests. Removing them so it won't block make. Signed-off-by: Yumei Huang <yuhuang(a)redhat.com> --- test/Makefile | 124 +------------------------------------------------- 1 file changed, 1 insertion(+), 123 deletions(-) diff --git a/test/Makefile b/test/Makefile index a774285..d7c37d6 100644 --- a/test/Makefile +++ b/test/Makefile @@ -9,51 +9,7 @@ BATS = bats -j $(shell nproc) EXETOOL = exeter/exetool/exetool WGET = wget -c -DEBIAN_IMGS = debian-8.11.0-openstack-amd64.qcow2 \ - debian-10-nocloud-amd64.qcow2 \ - debian-10-generic-arm64.qcow2 \ - debian-10-generic-ppc64el-20220911-1135.qcow2 \ - debian-11-nocloud-amd64.qcow2 \ - debian-11-generic-arm64.qcow2 \ - debian-11-generic-ppc64el.qcow2 \ - debian-sid-nocloud-amd64-daily.qcow2 \ - debian-sid-nocloud-arm64-daily.qcow2 \ - debian-sid-nocloud-ppc64el-daily.qcow2 - -FEDORA_IMGS = Fedora-Cloud-Base-26-1.5.x86_64.qcow2 \ - Fedora-Cloud-Base-27-1.6.x86_64.qcow2 \ - Fedora-Cloud-Base-28-1.1.x86_64.qcow2 \ - Fedora-Cloud-Base-28-1.1.aarch64.qcow2 \ - Fedora-Cloud-Base-29-1.2.x86_64.qcow2 \ - Fedora-Cloud-Base-29-1.2.aarch64.qcow2 \ - Fedora-Cloud-Base-30-1.2.x86_64.qcow2 \ - Fedora-Cloud-Base-30-1.2.aarch64.qcow2 \ - Fedora-Cloud-Base-31-1.9.x86_64.qcow2 \ - Fedora-Cloud-Base-31-1.9.aarch64.qcow2 \ - Fedora-Cloud-Base-32-1.6.x86_64.qcow2 \ - Fedora-Cloud-Base-32-1.6.aarch64.qcow2 \ - Fedora-Cloud-Base-33-1.2.x86_64.qcow2 \ - Fedora-Cloud-Base-33-1.2.aarch64.qcow2 \ - Fedora-Cloud-Base-34-1.2.x86_64.qcow2 \ - Fedora-Cloud-Base-34-1.2.aarch64.qcow2 \ - Fedora-Cloud-Base-35-1.2.x86_64.qcow2 \ - Fedora-Cloud-Base-35-1.2.aarch64.qcow2 - -OPENSUSE_IMGS = openSUSE-Leap-15.1-JeOS.x86_64-kvm-and-xen.qcow2 \ - openSUSE-Leap-15.2-JeOS.x86_64-kvm-and-xen.qcow2 \ - openSUSE-Leap-15.3-JeOS.x86_64-kvm-and-xen.qcow2 \ - openSUSE-Tumbleweed-ARM-JeOS-efi.aarch64.raw.xz \ - openSUSE-Tumbleweed-ARM-JeOS-efi.armv7l.raw.xz - -UBUNTU_OLD_IMGS = trusty-server-cloudimg-amd64-disk1.img \ - trusty-server-cloudimg-i386-disk1.img \ - trusty-server-cloudimg-ppc64el-disk1.img -UBUNTU_NEW_IMGS = xenial-server-cloudimg-powerpc-disk1.img \ - jammy-server-cloudimg-s390x.img -UBUNTU_IMGS = $(UBUNTU_OLD_IMGS) $(UBUNTU_NEW_IMGS) - -DOWNLOAD_ASSETS = exeter mbuto podman \ - $(DEBIAN_IMGS) $(FEDORA_IMGS) $(OPENSUSE_IMGS) $(UBUNTU_IMGS) +DOWNLOAD_ASSETS = exeter mbuto podman TESTDATA_ASSETS = small.bin big.bin medium.bin \ rampstream LOCAL_ASSETS = mbuto.img mbuto.mem.img podman/bin/podman QEMU_EFI.fd \ @@ -150,81 +106,3 @@ clean: realclean: clean rm -rf $(DOWNLOAD_ASSETS) -# Debian downloads -debian-8.11.0-openstack-%.qcow2: - $(WGET) -O $@ https://cloud.debian.org/images/cloud/OpenStack/archive/8.11.0/debian-8.11.… - -debian-10-nocloud-%.qcow2: - $(WGET) -O $@ https://cloud.debian.org/images/cloud/buster/latest/debian-10-nocloud-$*.qc… - -debian-10-generic-ppc64el-20220911-1135.qcow2: - $(WGET) -O $@ https://cloud.debian.org/images/cloud/buster/20220911-1135/debian-10-generi… - -debian-10-generic-%.qcow2: - $(WGET) -O $@ https://cloud.debian.org/images/cloud/buster/latest/debian-10-generic-$*.qc… - -debian-11-nocloud-%.qcow2: - $(WGET) -O $@ https://cloud.debian.org/images/cloud/bullseye/latest/debian-11-nocloud-$*.… - -debian-11-generic-%.qcow2: - $(WGET) -O $@ https://cloud.debian.org/images/cloud/bullseye/latest/debian-11-generic-$*.… - -debian-sid-nocloud-%-daily.qcow2: - $(WGET) -O $@ https://cloud.debian.org/images/cloud/sid/daily/latest/debian-sid-nocloud-$… - -# Fedora downloads -Fedora-Cloud-Base-26-1.5.%.qcow2: - $(WGET) -O $@ http://archives.fedoraproject.org/pub/archive/fedora/linux/releases/26/Clou… - -Fedora-Cloud-Base-27-1.6.%.qcow2: - $(WGET) -O $@ http://archives.fedoraproject.org/pub/archive/fedora/linux/releases/27/Clou… - -Fedora-Cloud-Base-28-1.1.%.qcow2: - $(WGET) -O $@ http://archives.fedoraproject.org/pub/archive/fedora/linux/releases/28/Clou… - -Fedora-Cloud-Base-29-1.2.%.qcow2: - $(WGET) -O $@ http://archives.fedoraproject.org/pub/archive/fedora/linux/releases/29/Clou… - -Fedora-Cloud-Base-30-1.2.%.qcow2: - $(WGET) -O $@ http://archives.fedoraproject.org/pub/archive/fedora/linux/releases/30/Clou… - -Fedora-Cloud-Base-31-1.9.%.qcow2: - $(WGET) -O $@ http://archives.fedoraproject.org/pub/archive/fedora/linux/releases/31/Clou… - -Fedora-Cloud-Base-32-1.6.%.qcow2: - $(WGET) -O $@ https://archives.fedoraproject.org/pub/archive/fedora/linux/releases/32/Clo… - -Fedora-Cloud-Base-33-1.2.%.qcow2: - $(WGET) -O $@ https://archives.fedoraproject.org/pub/archive/fedora/linux/releases/33/Clo… - -Fedora-Cloud-Base-34-1.2.%.qcow2: - $(WGET) -O $@ https://archives.fedoraproject.org/pub/archive/fedora/linux/releases/34/Clo… - -Fedora-Cloud-Base-35-1.2.%.qcow2: - $(WGET) -O $@ https://archives.fedoraproject.org/pub/archive/fedora/linux/releases/35/Clo… - -# OpenSuSE downloads -openSUSE-Leap-15.1-JeOS.x86_64-kvm-and-xen.qcow2: - $(WGET) -O $@ https://download.opensuse.org/distribution/leap/15.1/jeos/openSUSE-Leap-15.… - -openSUSE-Leap-15.2-JeOS.x86_64-kvm-and-xen.qcow2: - $(WGET) -O $@ https://download.opensuse.org/distribution/leap/15.2/appliances/openSUSE-Le… - -openSUSE-Leap-15.3-JeOS.x86_64-kvm-and-xen.qcow2: - $(WGET) -O $@ https://download.opensuse.org/distribution/leap/15.3/appliances/openSUSE-Le… - -openSUSE-Tumbleweed-ARM-JeOS-efi.aarch64.raw.xz: - $(WGET) -O $@ http://download.opensuse.org/ports/aarch64/tumbleweed/appliances/openSUSE-T… - -openSUSE-Tumbleweed-ARM-JeOS-efi.armv7l.raw.xz: - $(WGET) -O $@ http://download.opensuse.org/ports/armv7hl/tumbleweed/appliances/openSUSE-T… - -# Ubuntu downloads -trusty-server-cloudimg-%-disk1.img: - $(WGET) -O $@ https://cloud-images.ubuntu.com/trusty/current/trusty-server-cloudimg-$*-di… - -xenial-server-cloudimg-powerpc-disk1.img: - $(WGET) -O $@ https://cloud-images.ubuntu.com/xenial/current/xenial-server-cloudimg-power… - -jammy-server-cloudimg-s390x.img: - $(WGET) -O $@ https://cloud-images.ubuntu.com/jammy/current/jammy-server-cloudimg-s390x.i… -- 2.47.0

3 6

[PATCH] test: Fix QEMU_EFI.fd not found error on non-ARM platforms
by Yumei Huang 08 Sep '25

08 Sep '25

Fix the following error when running `make assets` under test on non-ARM platforms: ./find-arm64-firmware.sh QEMU_EFI.fd Couldn't find QEMU_EFI.fd make: *** [Makefile:68: QEMU_EFI.fd] Error 1 Signed-off-by: Yumei Huang <yuhuang(a)redhat.com> --- test/Makefile | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/test/Makefile b/test/Makefile index a774285..32d6b43 100644 --- a/test/Makefile +++ b/test/Makefile @@ -109,7 +109,11 @@ nstool: nstool.c $(CC) $(CFLAGS) -o $@ $^ QEMU_EFI.fd: - ./find-arm64-firmware.sh $@ + if [ "$(shell uname -m)" = "aarch64" ]; then \ + ./find-arm64-firmware.sh $@; \ + else \ + echo "QEMU_EFI.fd not needed on $(shell uname -m)" && touch $@; \ + fi prepared-%.qcow2: %.qcow2 ./prepare-distro-img.sh qemu-img create -f qcow2 -F qcow2 -b $< $@ -- 2.47.0

3 4

[PATCH v3] test: Remove distro images from DOWNLOAD_ASSETS
by Yumei Huang 08 Sep '25

08 Sep '25

Some of the download links are broken, and none of the images are used in current tests. Removing them from DOWNLOAD_ASSETS so it won't block make per David's suggestion. Signed-off-by: Yumei Huang <yuhuang(a)redhat.com> --- test/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/Makefile b/test/Makefile index a774285..dc096c5 100644 --- a/test/Makefile +++ b/test/Makefile @@ -52,8 +52,7 @@ UBUNTU_NEW_IMGS = xenial-server-cloudimg-powerpc-disk1.img \ jammy-server-cloudimg-s390x.img UBUNTU_IMGS = $(UBUNTU_OLD_IMGS) $(UBUNTU_NEW_IMGS) -DOWNLOAD_ASSETS = exeter mbuto podman \ - $(DEBIAN_IMGS) $(FEDORA_IMGS) $(OPENSUSE_IMGS) $(UBUNTU_IMGS) +DOWNLOAD_ASSETS = exeter mbuto podman TESTDATA_ASSETS = small.bin big.bin medium.bin \ rampstream LOCAL_ASSETS = mbuto.img mbuto.mem.img podman/bin/podman QEMU_EFI.fd \ -- 2.47.0

2 1

[PATCH v2] test: Remove distro images from LOCAL_ASSETS
by Yumei Huang 08 Sep '25

08 Sep '25

Some of the download links are broken, and none of the images are used in current tests. Removing them from LOCAL_ASSETS so it won't block make per David's suggestion. Signed-off-by: Yumei Huang <yuhuang(a)redhat.com> --- test/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/Makefile b/test/Makefile index a774285..dc096c5 100644 --- a/test/Makefile +++ b/test/Makefile @@ -52,8 +52,7 @@ UBUNTU_NEW_IMGS = xenial-server-cloudimg-powerpc-disk1.img \ jammy-server-cloudimg-s390x.img UBUNTU_IMGS = $(UBUNTU_OLD_IMGS) $(UBUNTU_NEW_IMGS) -DOWNLOAD_ASSETS = exeter mbuto podman \ - $(DEBIAN_IMGS) $(FEDORA_IMGS) $(OPENSUSE_IMGS) $(UBUNTU_IMGS) +DOWNLOAD_ASSETS = exeter mbuto podman TESTDATA_ASSETS = small.bin big.bin medium.bin \ rampstream LOCAL_ASSETS = mbuto.img mbuto.mem.img podman/bin/podman QEMU_EFI.fd \ -- 2.47.0

1 1

[PATCH v8 0/5] Introduce first exeter based test infrastructure
by David Gibson 08 Sep '25

08 Sep '25

Here's a new approach to building passt tests with exeter. This new one no longer uses Avocado in the default case, although it would still be possible to manually run the exeter based tests with Avocado. For now this only does simple tests, to show how the integration could work. It adds some new trivial "smoke tests" and converts the linter and build checks to exeter. More complex tests will require building the tunbridge library we've discussed. A lot of the work for that already exists in my earlier exeter test series, but it will need some rework to split it into a separate component. v8: * Create video links for exeter tests too * Fix some bad indenting v7: * Use "exetool list" rather than "--list" directly to get test manifest. * Update Makefiles to automatically update exeter sources as necessary. * Update series cover letter removing some outdated information. v6: * Use exeter's new metadata support to print nicer test names v5: * Updated according to Stefano's review - Fixed a number of whitespace errors - Improved many comments and variable names to make things clearer * New patch adding parallel test execution with BATS * Improved autodetection of exeter tests using "exetool probe" David Gibson (5): test: Extend test scripts to allow running exeter tests. test: Run static checkers as exeter tests test: Convert build tests to exeter test: Allow exeter & podman tests to be parallel executed with BATS test: Explicit specify forwarding ports for pasta in log rotation tests test/.gitignore | 2 + test/Makefile | 24 +++++++- test/build/all | 61 ------------------ test/build/build.py | 109 +++++++++++++++++++++++++++++++++ test/build/clang_tidy | 17 ----- test/build/cppcheck | 17 ----- test/build/static_checkers.sh | 26 ++++++++ test/lib/exeter | 58 ++++++++++++++++++ test/pasta_options/log_to_file | 10 +-- test/run | 18 ++++-- test/smoke/smoke.sh | 33 ++++++++++ 11 files changed, 267 insertions(+), 108 deletions(-) delete mode 100644 test/build/all create mode 100755 test/build/build.py delete mode 100644 test/build/clang_tidy delete mode 100644 test/build/cppcheck create mode 100755 test/build/static_checkers.sh create mode 100644 test/lib/exeter create mode 100755 test/smoke/smoke.sh -- 2.51.0

2 10

[PATCH v7 0/4] Introduce first exeter based test infrastructure
by David Gibson 08 Sep '25

08 Sep '25

Here's a new approach to building passt tests with exeter. This new one no longer uses Avocado in the default case, although it would still be possible to manually run the exeter based tests with Avocado. For now this only does simple tests, to show how the integration could work. It adds some new trivial "smoke tests" and converts the linter and build checks to exeter. More complex tests will require building the tunbridge library we've discussed. A lot of the work for that already exists in my earlier exeter test series, but it will need some rework to split it into a separate component. v7: * Use "exetool list" rather than "--list" directly to get test manifest. * Update Makefiles to automatically update exeter sources as necessary. * Update series cover letter removing some outdated information. v6: * Use exeter's new metadata support to print nicer test names v5: * Updated according to Stefano's review - Fixed a number of whitespace errors - Improved many comments and variable names to make things clearer * New patch adding parallel test execution with BATS * Improved autodetection of exeter tests using "exetool probe" David Gibson (4): test: Extend test scripts to allow running exeter tests. test: Run static checkers as exeter tests test: Convert build tests to exeter test: Allow exeter & podman tests to be parallel executed with BATS test/.gitignore | 2 + test/Makefile | 24 +++++++- test/build/all | 61 ------------------- test/build/build.py | 109 ++++++++++++++++++++++++++++++++++ test/build/clang_tidy | 17 ------ test/build/cppcheck | 17 ------ test/build/static_checkers.sh | 26 ++++++++ test/lib/exeter | 57 ++++++++++++++++++ test/run | 18 ++++-- test/smoke/smoke.sh | 33 ++++++++++ 10 files changed, 261 insertions(+), 103 deletions(-) delete mode 100644 test/build/all create mode 100755 test/build/build.py delete mode 100644 test/build/clang_tidy delete mode 100644 test/build/cppcheck create mode 100755 test/build/static_checkers.sh create mode 100644 test/lib/exeter create mode 100755 test/smoke/smoke.sh -- 2.51.0

2 9

[PATCH] Send an initial ARP request to resolve the guest IP address
by Volker Diels-Grabsch 07 Sep '25

07 Sep '25

When restarting passt while QEMU keeps running with a configured "reconnect-ms" setting, the port forwardings will stop working until the guest sends some outgoing network traffic. Reason: Although QEMU reconnects successfully to the unix domain socket of the new passt process, that one no longer knows the guest's MAC address and uses instead a broadcast MAC address. However, this is ignored by the guest, at least if the guest runs Linux. Only after the guest sends some network package on its own initiative, passt will know the MAC address and will be able to establish forwarded connections. This change fixes this issue by sending an ARP request to resolve the guest's MAC address via its IP address, which we do know, right after the unix domain socket (re)connection. The only case where the IP is "wrong" would be if the configuration changed, and/or on the very first start right after qemu started. But in those cases, we just wouldn't get an ARP response, and can't do anything receive the guest's DHCP request - just as before. In other words, in the worst case an ARP request would be harmless. Signed-off-by: Volker Diels-Grabsch <v(a)njh.eu> --- arp.c | 34 ++++++++++++++++++++++++++++++++++ arp.h | 1 + tap.c | 15 +++++++++++++-- 3 files changed, 48 insertions(+), 2 deletions(-) diff --git a/arp.c b/arp.c index 44677ad..561581a 100644 --- a/arp.c +++ b/arp.c @@ -112,3 +112,37 @@ int arp(const struct ctx *c, struct iov_tail *data) return 1; } + +/** + * send_initial_arp_req() - Send initial ARP request to retrieve guest MAC address + * @c: Execution context + */ +void send_initial_arp_req(const struct ctx *c) +{ + struct { + struct ethhdr eh; + struct arphdr ah; + struct arpmsg am; + } __attribute__((__packed__)) req; + + /* Ethernet header */ + req.eh.h_proto = htons(ETH_P_ARP); + memcpy(req.eh.h_dest, c->guest_mac, sizeof(req.eh.h_dest)); + memcpy(req.eh.h_source, c->our_tap_mac, sizeof(req.eh.h_source)); + + /* ARP header */ + req.ah.ar_op = htons(ARPOP_REQUEST); + req.ah.ar_hrd = htons(ARPHRD_ETHER); + req.ah.ar_pro = htons(ETH_P_IP); + req.ah.ar_hln = ETH_ALEN; + req.ah.ar_pln = 4; + + /* ARP message */ + memcpy(req.am.sha, c->our_tap_mac, sizeof(req.am.sha)); + memcpy(req.am.sip, &c->ip4.our_tap_addr, sizeof(req.am.sip)); + memcpy(req.am.tha, c->guest_mac, sizeof(req.am.tha)); + memcpy(req.am.tip, &c->ip4.addr, sizeof(req.am.tip)); + + info("sending initial ARP request to retrieve guest MAC address after reconnect"); + tap_send_single(c, &req, sizeof(req)); +} diff --git a/arp.h b/arp.h index 86bcbf8..5490144 100644 --- a/arp.h +++ b/arp.h @@ -21,5 +21,6 @@ struct arpmsg { } __attribute__((__packed__)); int arp(const struct ctx *c, struct iov_tail *data); +void send_initial_arp_req(const struct ctx *c); #endif /* ARP_H */ diff --git a/tap.c b/tap.c index 7ba6399..47dedd5 100644 --- a/tap.c +++ b/tap.c @@ -1355,6 +1355,16 @@ static void tap_start_connection(const struct ctx *c) ev.events = EPOLLIN | EPOLLRDHUP; ev.data.u64 = ref.u64; epoll_ctl(c->epollfd, EPOLL_CTL_ADD, c->fd_tap, &ev); + + switch (c->mode) { + case MODE_PASST: + send_initial_arp_req(c); + break; + case MODE_PASTA: + break; + case MODE_VU: + break; + } } /** @@ -1504,8 +1514,9 @@ void tap_backend_init(struct ctx *c) tap_sock_unix_init(c); /* In passt mode, we don't know the guest's MAC address until it - * sends us packets. Use the broadcast address so that our - * first packets will reach it. + * sends us packets (e.g. responds to our initial ARP request). + * Until then, use the broadcast address so that our first + * packets will reach it. */ memset(&c->guest_mac, 0xff, sizeof(c->guest_mac)); break; -- 2.47.2

1 1

[PATCH] Add missing explicit PSH assignment
by Volker Diels-Grabsch 07 Sep '25

07 Sep '25

For packets with data, we set the PSH flag depending on whether it's the last chunk of data in a single receive operation from a socket. But then we reuse the same buffers for SYN segments, and oops, PSH is set randomly. This change cleans this up by setting PSH explicitly, just as we do with the other flags. --- tcp.c | 1 + tcp_internal.h | 1 + 2 files changed, 2 insertions(+) diff --git a/tcp.c b/tcp.c index dba5fdc..a27b069 100644 --- a/tcp.c +++ b/tcp.c @@ -1176,6 +1176,7 @@ int tcp_prepare_flags(const struct ctx *c, struct tcp_tap_conn *conn, th->doff = (sizeof(*th) + *optlen) / 4; th->ack = !!(flags & ACK); + th->psh = !!(flags & PSH); th->rst = !!(flags & RST); th->syn = !!(flags & SYN); th->fin = !!(flags & FIN); diff --git a/tcp_internal.h b/tcp_internal.h index 36c6533..9dae688 100644 --- a/tcp_internal.h +++ b/tcp_internal.h @@ -26,6 +26,7 @@ #define FIN (1 << 0) #define SYN (1 << 1) #define RST (1 << 2) +#define PSH (1 << 3) #define ACK (1 << 4) /* Flags for internal usage */ -- 2.47.2

2 2

[PATCH] Fix typo in doc comment
by Volker Diels-Grabsch 06 Sep '25

06 Sep '25

--- passt.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/passt.h b/passt.h index 4cfd6eb..3ffc19f 100644 --- a/passt.h +++ b/passt.h @@ -208,7 +208,7 @@ struct ip6_ctx { * @guest_mac: MAC address of guest or namespace, seen or configured * @hash_secret: 128-bit secret for siphash functions * @ifi4: Template interface for IPv4, -1: none, 0: IPv4 disabled - * @ip: IPv4 configuration + * @ip4: IPv4 configuration * @dns_search: DNS search list * @hostname: Guest hostname * @fqdn: Guest FQDN -- 2.47.2

2 1