- dev - passt

[PATCH 0/2] test: Fix two issues made apparent by new command dispatch
by Stefano Brivio 19 Sep '22

19 Sep '22

This is based on pending series by David, but they're logically separated fixes, so I'm sending them as a different series. Patch 2/2 adds some 'sleep 1' commands that were previously missing, which actually goes against the intention of speeding up those tests. However, without those, a number of tests fail quite frequently due to races between starting server and client, and I could never get a clean run with the new command dispatch mechanism otherwise. We can probably find a more elegant (and time-saving) mechanism to make sure the server is ready (based e.g. on parsing its output), but at the moment I'm just trying to make the test suite work again for me in its entirety. Stefano Brivio (2): test/perf: Check for /sbin/sysctl with which(1), not simply sysctl test/passt_in_ns: Consistent sleep commands before starting socat client test/passt_in_ns/tcp | 29 +++++++++++++++++++++++++---- test/passt_in_ns/udp | 18 ++++++++++++++++-- test/perf/passt_tcp | 4 ++-- test/perf/passt_udp | 2 +- test/perf/pasta_tcp | 2 +- 5 files changed, 45 insertions(+), 10 deletions(-) -- 2.35.1

2 13

[PATCH 0/2] doc/demo: Fix two issues seen on Fedora 36
by Stefano Brivio 17 Sep '22

17 Sep '22

Stefano Brivio (2): doc/demo: Drop /sbin from dhclient command, pass script file explicitly doc/demo: Clone and use mbuto in init namespace doc/demo.sh | 30 +++++++++++++++++++++--------- 1 file changed, 21 insertions(+), 9 deletions(-) -- 2.35.1

2 5

[PATCH] README: Update Availability and Try It sections with new packages
by Stefano Brivio 17 Sep '22

17 Sep '22

We now have official packages for Fedora, unofficial (Fedora Copr) for other common RPM-based distributions, and the existing packages with static builds for Debian, and for other RPM-based distributions. Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com> --- README.md | 57 +++++++++++++++++++++++++++++++------------------------ 1 file changed, 32 insertions(+), 25 deletions(-) diff --git a/README.md b/README.md index 2d7ae3c..fb09c6a 100644 --- a/README.md +++ b/README.md @@ -339,15 +339,19 @@ speeding up local connections, and usually requiring NAT. _pasta_: * ⌚ drop-in replacement for VPNKit (rootless Docker) ### Availability -* ✅ convenience unofficial packages for Debian, RPM-based distributions on - x86_64 (static builds) +* ✅ official [packages](https://src.fedoraproject.org/rpms/passt) for Fedora +* ✅ unofficial + [packages](https://copr.fedorainfracloud.org/coprs/sbrivio/passt/) for CentOS + Stream, EPEL, Mageia, OpenSUSE +* ✅ unofficial packages from x86_64 static builds for other RPM-based + distributions and Debian * ✅ testing on non-x86_64 architectures (aarch64, armv7l, i386, ppc64, ppc64le, s390x) -* ✅ example Debian [package files](/passt/tree/contrib/debian), - example [`spec` file](/passt/tree/contrib/fedora) for Fedora +* ✅ example Debian [package files](/passt/tree/contrib/debian) * 🛠 official [OpenSUSE packages](https://build.opensuse.org/package/show/home:mnhauke/passt) -* ⌚ official packages for Debian, Fedora, etc. +* ⌚ official packages for Debian + ([RFP](https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1010498)), Arch Linux ### Services * ✅ built-in [ARP proxy](/passt/tree/arp.c) @@ -530,16 +534,19 @@ See also the [test logs](/builds/latest/test/). cd passt make - * alternatively, [static builds](/builds/latest/x86_64/) for x86_64 as of - the latest commit are also available for convenience. Non-official - packages for Debian (and derivatives) and RPM-based distributions are also - available there. These binaries and packages are simply built with: + * alternatively, install one of the available packages: - make pkgs + * [Debian and Debian-based](/builds/latest/x86_64/) (unofficial, from static x86_64 builds) + * [Fedora](https://src.fedoraproject.org/rpms/passt) (official) + * [CentOS Stream](https://copr.fedorainfracloud.org/coprs/sbrivio/passt/) (unofficial) + * [EPEL](https://copr.fedorainfracloud.org/coprs/sbrivio/passt/) (unofficial) + * [Mageia](https://copr.fedorainfracloud.org/coprs/sbrivio/passt/) (unofficial) + * [OpenSUSE](https://copr.fedorainfracloud.org/coprs/sbrivio/passt/) (unofficial) + * [Other RPM-based distributions](/builds/latest/x86_64/) (unofficial, from static x86_64 builds) - * or use one of the unofficial - [repositories](https://copr.fedorainfracloud.org/coprs/sbrivio/passt/) for - CentOS Stream, EPEL, Fedora, Mageia and OpenSUSE Tumbleweed + Static binaries and packages are simply built with: + + make pkgs * have a look at the _man_ page for synopsis and options: @@ -565,10 +572,7 @@ See also the [test logs](/builds/latest/test/). echo working from/to the guest for IPv4 and IPv6 * to connect to a service on the VM, just connect to the same port directly - with the address of the network namespace. For example, to ssh to the guest, - from the main namespace on the host: - - ssh 192.0.2.2 + with the address of the current network namespace ### pasta @@ -578,16 +582,19 @@ See also the [test logs](/builds/latest/test/). cd passt make - * alternatively, [static builds](/builds/latest/x86_64/) for x86_64 as of - the latest commit are also available for convenience. Non-official - packages for Debian (and derivatives) and RPM-based distributions are also - available there. These binaries and packages are simply built with: + * alternatively, install one of the available packages: + + * [Debian and Debian-based](/builds/latest/x86_64/) (unofficial, from static x86_64 builds) + * [Fedora](https://src.fedoraproject.org/rpms/passt) (official) + * [CentOS Stream](https://copr.fedorainfracloud.org/coprs/sbrivio/passt/) (unofficial) + * [EPEL](https://copr.fedorainfracloud.org/coprs/sbrivio/passt/) (unofficial) + * [Mageia](https://copr.fedorainfracloud.org/coprs/sbrivio/passt/) (unofficial) + * [OpenSUSE](https://copr.fedorainfracloud.org/coprs/sbrivio/passt/) (unofficial) + * [Other RPM-based distributions](/builds/latest/x86_64/) (unofficial, from static x86_64 builds) - make pkgs + Static binaries and packages are simply built with: - * or use one of the unofficial - [repositories](https://copr.fedorainfracloud.org/coprs/sbrivio/passt/) for - CentOS Stream, EPEL, Fedora, Mageia and OpenSUSE Tumbleweed + make pkgs * have a look at the _man_ page for synopsis and options: -- 2.35.1

1 0

[PATCH] Makefile: Include seccomp.h in HEADERS and require it for static checkers
by Stefano Brivio 14 Sep '22

14 Sep '22

Targets running static checkers (cppcheck and clang-tidy) need seccomp.h, but the latter is not included in HEADERS. Add it. Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com> --- Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 6805c23..c47a5f6 100644 --- a/Makefile +++ b/Makefile @@ -42,7 +42,7 @@ MANPAGES = passt.1 pasta.1 qrap.1 PASST_HEADERS = arch.h arp.h checksum.h conf.h dhcp.h dhcpv6.h icmp.h \ isolation.h lineread.h ndp.h netlink.h packet.h passt.h pasta.h \ pcap.h siphash.h tap.h tcp.h tcp_splice.h udp.h util.h -HEADERS = $(PASST_HEADERS) +HEADERS = $(PASST_HEADERS) seccomp.h # On gcc 11.2, with -O2 and -flto, tcp_hash() and siphash_20b(), if inlined, # seem to be hitting something similar to: @@ -104,11 +104,11 @@ static: clean all seccomp.h: $(PASST_SRCS) $(PASST_HEADERS) @ EXTRA_SYSCALLS=$(EXTRA_SYSCALLS) ./seccomp.sh $^ -passt: $(PASST_SRCS) $(PASST_HEADERS) seccomp.h +passt: $(PASST_SRCS) $(HEADERS) $(CC) $(FLAGS) $(CFLAGS) $(PASST_SRCS) -o passt $(LDFLAGS) passt.avx2: FLAGS += -Ofast -mavx2 -ftree-vectorize -funroll-loops -passt.avx2: $(PASST_SRCS) $(PASST_HEADERS) seccomp.h +passt.avx2: $(PASST_SRCS) $(HEADERS) $(CC) $(filter-out -O2,$(FLAGS) $(CFLAGS)) \ $(PASST_SRCS) -o passt.avx2 $(LDFLAGS) -- 2.35.1

2 1

[PATCH] test: term: When checking if status line is a number, hide errors
by Stefano Brivio 14 Sep '22

14 Sep '22

We use the [ "$x" -eq "$x" ] syntax to check if $x is a number. The behaviour is clearly implied by POSIX, but some shells might actually report the (intended) error, and dash floods script.log with "Illegal number" error messages. Hide them. Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com> --- test/lib/term | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/lib/term b/test/lib/term index b31deac..eade2cd 100755 --- a/test/lib/term +++ b/test/lib/term @@ -232,7 +232,7 @@ pane_status() { [ ${DEMO} -eq 1 ] && return 0 __status="$(pane_parse "${1}")" - while ! [ "${__status}" -eq "${__status}" ]; do + while ! [ "${__status}" -eq "${__status}" ] 2>/dev/null; do sleep 1 pane_run "${1}" 'echo $?' pane_wait "${1}" -- 2.35.1

2 1

[PATCH 0/2] Don't drop outbound zero-length UDP packets over tap
by David Gibson 13 Sep '22

13 Sep '22

passt/pasta was incorrectly dropping UDP packets with a zero-length payload when travelling out via the tap interface. This is incorrect, since for a datagram protocol, zero-length packets are still meaningful. Based on my earlier series for test command dispatch, user namespace cleanup and test temporary file handling. Bugzilla: https://bugs.passt.top/show_bug.cgi?id=19 David Gibson (2): udp: Don't drop zero-length outbound UDP packets test: Simpler termination handling for UDP tests test/passt/udp | 23 +++++++------- test/passt_in_ns/udp | 73 ++++++++++++++++++++++---------------------- test/pasta/udp | 31 +++++++++---------- udp.c | 10 +++--- 4 files changed, 67 insertions(+), 70 deletions(-) -- 2.37.3

2 8

[PATCH v2 0/3] Don't drop outbound zero-length UDP packets over tap
by David Gibson 13 Sep '22

13 Sep '22

passt/pasta was incorrectly dropping UDP packets with a zero-length payload when travelling out via the tap interface. This is incorrect, since for a datagram protocol, zero-length packets are still meaningful. Based on my earlier series for test command dispatch, user namespace cleanup and test temporary file handling. Bugzilla: https://bugs.passt.top/show_bug.cgi?id=19 Changes since v1: * Also remove unnecessary initialization of mm[] David Gibson (3): udp: Don't pre-initialize msghdr array udp: Don't drop zero-length outbound UDP packets test: Simpler termination handling for UDP tests test/passt/udp | 23 +++++++------- test/passt_in_ns/udp | 73 ++++++++++++++++++++++---------------------- test/pasta/udp | 31 +++++++++---------- udp.c | 23 +++++++++----- 4 files changed, 77 insertions(+), 73 deletions(-) -- 2.37.3

1 3

[PATCH v2 00/10] Clean up handling of userns
by David Gibson 13 Sep '22

13 Sep '22

Sorry for the resend, but I found a bug that means this will fail to build on some distros / versions. Our handling of user namespaces is more complex than it needs to be. This simplifies the handling by identifying and entering (or creating) the correct userns earlier, so that later code doesn't need to deal with it any more. Along the way we make a number of other cleanups to handling of userns and setting our user and group. This is based on my earlier test command dispatch and performance test cleanup series. Changes since v1: * Fixed overenthusiastic pruning of #includes when moving the self-isolation code which broke compile on some distro versions David Gibson (10): Don't store UID & GID persistently in the context structure Split checking for root from dropping root privilege Consolidate determination of UID/GID to run as Safer handling if we can't open /proc/self/uid_map Move self-isolation code into a separate file Consolidate validation of pasta namespace options Clean up and rename conf_ns_open() Correctly handle --netns-only in pasta_start_ns() Handle userns isolation and dropping root at the same time Allow --userns when pasta spawns a command Makefile | 8 +- conf.c | 236 ++++++++++++++++++++++++++-------------------------- isolation.c | 210 ++++++++++++++++++++++++++++++++++++++++++++++ isolation.h | 15 ++++ passt.1 | 5 +- passt.c | 116 +------------------------- passt.h | 9 -- pasta.c | 91 ++++++++++++-------- pasta.h | 1 + util.c | 83 ------------------ util.h | 2 - 11 files changed, 412 insertions(+), 364 deletions(-) create mode 100644 isolation.c create mode 100644 isolation.h -- 2.37.3

2 32

[PATCH v4 00/12] Improve handling of test temporary files
by David Gibson 13 Sep '22

13 Sep '22

Sigh. Even more silly errors The tests create temporary files and fifos in a number of places. Some of them can interfere with later test runs, and are awkward to clean up. Consolidate them in a single per-run directory in /tmp which gets cleaned up automatically. This is based on the earlier userns cleanup series. Changes since v3: * Fixed problem with ssh hosts file naming which caused a bunch of non-fatal warnings Changes since v2: * Reinstated patch to move the log pipe accidentally dropped during a rebase Chances since v1: * Fixed a number of straightforward bugs where things were missed * Also removed files we're no longer putting into the source tree from .gitignore * Added an extra patch moving the video processing files David Gibson (12): test: Group tests by context then protocol, rather than the reverse test: Remove unused variable FFMPEG_PID_FILE test: Actually run cleanup function test: Create common state directories for temporary files test: Move passt_test_log_pipe to state directory test: Move context temporary files to state dir test: Dont regnerate small test file in pasta/tcp test: Use paths in __STATEDIR__ instead of 'temp' and 'tempdir' directives test: Move pause temporary file to state directory test: Store pcap files in $LOGDIR instead of /tmp test: Move pidfiles and nsholder sockets into state directory test: Move video processing files to $STATEBASE .gitignore | 1 - test/.gitignore | 3 - test/build/all | 31 ++++--- test/demo/passt | 9 +- test/demo/pasta | 12 ++- test/demo/podman | 11 ++- test/distro/debian | 2 +- test/distro/fedora | 2 +- test/distro/opensuse | 16 ++-- test/distro/ubuntu | 8 +- test/lib/context | 61 +++++++------- test/lib/layout | 16 ++-- test/lib/setup | 84 ++++++++++--------- test/lib/term | 26 +++--- test/lib/test | 14 +--- test/lib/video | 20 ++--- test/{dhcp/passt => passt/dhcp} | 2 +- test/{ndp/passt => passt/ndp} | 2 +- test/{shutdown/passt => passt/shutdown} | 4 +- test/{tcp/passt => passt/tcp} | 6 +- test/{udp/passt => passt/udp} | 8 +- test/{icmp/passt_in_ns => passt_in_ns/icmp} | 2 +- .../passt_in_ns => passt_in_ns/shutdown} | 4 +- test/{tcp/passt_in_ns => passt_in_ns/tcp} | 10 +-- test/{udp/passt_in_ns => passt_in_ns/udp} | 8 +- test/{dhcp/pasta => pasta/dhcp} | 2 +- test/{ndp/pasta => pasta/ndp} | 2 +- test/{tcp/pasta => pasta/tcp} | 13 ++- test/{udp/pasta => pasta/udp} | 20 ++--- test/run | 48 +++++------ 30 files changed, 217 insertions(+), 230 deletions(-) rename test/{dhcp/passt => passt/dhcp} (98%) rename test/{ndp/passt => passt/ndp} (95%) rename test/{shutdown/passt => passt/shutdown} (80%) rename test/{tcp/passt => passt/tcp} (96%) rename test/{udp/passt => passt/udp} (88%) rename test/{icmp/passt_in_ns => passt_in_ns/icmp} (94%) rename test/{shutdown/passt_in_ns => passt_in_ns/shutdown} (79%) rename test/{tcp/passt_in_ns => passt_in_ns/tcp} (97%) rename test/{udp/passt_in_ns => passt_in_ns/udp} (97%) rename test/{dhcp/pasta => pasta/dhcp} (96%) rename test/{ndp/pasta => pasta/ndp} (95%) rename test/{tcp/pasta => pasta/tcp} (95%) rename test/{udp/pasta => pasta/udp} (74%) -- 2.37.3

2 19

[PATCH v5 00/14] Improve handling of test temporary files
by David Gibson 13 Sep '22

13 Sep '22

The tests create temporary files and fifos in a number of places. Some of them can interfere with later test runs, and are awkward to clean up. Consolidate them in a single per-run directory in /tmp which gets cleaned up automatically. This is based on the earlier userns cleanup series. Changes since v4: * Also moved .pid files from demo into state directory * Moved the .cast video files into $LOGDIR/web instead of plain $LOGDIR * Added a new patch moving the perf.js report into $LOGDIR/web too * Updated hooks/pre-push to take things from their new directories Changes since v3: * Fixed problem with ssh hosts file naming which caused a bunch of non-fatal warnings Changes since v2: * Reinstated patch to move the log pipe accidentally dropped during a rebase Chances since v1: * Fixed a number of straightforward bugs where things were missed * Also removed files we're no longer putting into the source tree from .gitignore * Added an extra patch moving the video processing files David Gibson (14): test: Group tests by mode then protocol, rather than the reverse test: Remove unused variable FFMPEG_PID_FILE test: Actually run cleanup function test: Create common state directories for temporary files test: Move passt_test_log_pipe to state directory test: Move context temporary files to state dir test: Don't redundantly regenerate small test file in pasta/tcp test: Use paths in __STATEDIR__ instead of 'temp' and 'tempdir' directives test: Move pause temporary file to state directory test: Store pcap files in $LOGDIR instead of /tmp test: Move pidfiles and nsholder sockets into state directory demo: Move pidfiles to state directory test: Move video processing files to $STATEBASE test: Move perf.js report file to $LOGDIR/web .gitignore | 1 - hooks/pre-push | 12 +-- test/.gitignore | 5 -- test/build/all | 31 ++++--- test/demo/passt | 14 ++-- test/demo/pasta | 20 ++--- test/demo/podman | 11 ++- test/distro/debian | 2 +- test/distro/fedora | 2 +- test/distro/opensuse | 16 ++-- test/distro/ubuntu | 8 +- test/lib/context | 61 +++++++------- test/lib/layout | 16 ++-- test/lib/perf_report | 3 +- test/lib/setup | 84 ++++++++++--------- test/lib/term | 26 +++--- test/lib/test | 14 +--- test/lib/video | 38 +++++---- test/{dhcp/passt => passt/dhcp} | 2 +- test/{ndp/passt => passt/ndp} | 2 +- test/{shutdown/passt => passt/shutdown} | 4 +- test/{tcp/passt => passt/tcp} | 6 +- test/{udp/passt => passt/udp} | 8 +- test/{icmp/passt_in_ns => passt_in_ns/icmp} | 2 +- .../passt_in_ns => passt_in_ns/shutdown} | 4 +- test/{tcp/passt_in_ns => passt_in_ns/tcp} | 10 +-- test/{udp/passt_in_ns => passt_in_ns/udp} | 8 +- test/{dhcp/pasta => pasta/dhcp} | 2 +- test/{ndp/pasta => pasta/ndp} | 2 +- test/{tcp/pasta => pasta/tcp} | 13 ++- test/{udp/pasta => pasta/udp} | 20 ++--- test/run | 48 +++++------ 32 files changed, 243 insertions(+), 252 deletions(-) rename test/{dhcp/passt => passt/dhcp} (98%) rename test/{ndp/passt => passt/ndp} (95%) rename test/{shutdown/passt => passt/shutdown} (80%) rename test/{tcp/passt => passt/tcp} (96%) rename test/{udp/passt => passt/udp} (88%) rename test/{icmp/passt_in_ns => passt_in_ns/icmp} (94%) rename test/{shutdown/passt_in_ns => passt_in_ns/shutdown} (79%) rename test/{tcp/passt_in_ns => passt_in_ns/tcp} (97%) rename test/{udp/passt_in_ns => passt_in_ns/udp} (97%) rename test/{dhcp/pasta => pasta/dhcp} (96%) rename test/{ndp/pasta => pasta/ndp} (95%) rename test/{tcp/pasta => pasta/tcp} (95%) rename test/{udp/pasta => pasta/udp} (74%) -- 2.37.3

1 14