Here's my latest revision of some of the basics of the flow table. So
far it's basically just a renaming of the existing TCP connection
table, along with some associated helpers. It's used for some new
logging infrastructure, but otherwise doesn't really function any
differently.
However, this subset of the flow table work no longer bloats
flow/connection entries over a single cache line. That removes the
most prominent drawback of earlier revisions, meaning I think this
series is ready for merge now. Doing so will mean the later series
making more substantive changes to the flow behaviour are simpler.
Tested on top of the patch updating shell prompt escape handling, but
should be independent of it.
Changes since v1:
* Removed a inaccurate stale comment
* Added doc comment to FLOW() macro
* Added new patches cleaning up signedness of 'side' variables
* Added new patches introducing "sidx"s (flow+side indices)
David Gibson (11):
flow, tcp: Generalise connection types
flow, tcp: Move TCP connection table to unified flow table
flow, tcp: Consolidate flow pointer<->index helpers
util: MAX_FROM_BITS() should be unsigned
flow: Make unified version of flow table compaction
flow, tcp: Add logging helpers for connection related messages
flow: Introduce 'sidx' type to represent one side of one flow
tcp: Remove unneccessary bounds check in tcp_timer_handler()
flow,tcp: Generalise TCP epoll_ref to generic flows
tcp_splice: Use unsigned to represent side
flow,tcp: Use epoll_ref type including flow and side
Makefile | 14 +--
flow.c | 84 ++++++++++++++++++
flow.h | 73 ++++++++++++++++
flow_table.h | 86 ++++++++++++++++++
passt.h | 13 ++-
tcp.c | 243 ++++++++++++++++++++++++---------------------------
tcp.h | 5 --
tcp_conn.h | 46 +++-------
tcp_splice.c | 128 ++++++++++++---------------
tcp_splice.h | 2 +-
util.h | 2 +-
11 files changed, 440 insertions(+), 256 deletions(-)
create mode 100644 flow.c
create mode 100644 flow.h
create mode 100644 flow_table.h
--
2.43.0