On Sun, May 17, 2026 at 11:07:47AM +1000, David Gibson wrote:
A last minute fixup to commit e51494552b78 was misapplied. Instead of improving the implementation of assert_with_msg() for the case where NDEBUG is defined, it effectively eliminated assert_with_msg() in the normal case where NDEBUG is _not_ defined. As well as removing assert()s which protect us in case of certian types of bug, this introduces some cppcheck and clang-tidy regressions.
Fixes: e51494552b78 ("Fix build with -DNDEBUG") Signed-off-by: David Gibson
Sorry, sent this (identical) "v2" with a mistype. -- David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson