On Tue, 9 Jun 2026 16:30:01 +1000
David Gibson
As discussed on our recent call, I was looking again at bug 167. I discovered it's still fairly fiddly to address this, but while investigating spotted a number of cleanups to make in the vicinity. I think they make sense even without fixing bug 167 (yet), so here they are.
David Gibson (4): flow: Correct misleading signature of flowside_sock_l4() Makefile: Remove unused DUAL_STACK_SOCKETS define fwd, pif: Remove duplicated logic between tcp_listen() and udp_listen() pif, util: Move listen(2) call from sock_l4_() to pif_listen()
I was about to apply this (there are no apparent conflicts with "[PATCH 0/4] RFC: Improvements to flow specific logging", which I still need to review), but cppcheck now says: --- flow.c:216:31: style: inconclusive: Function 'flowside_sock_l4' argument 4 names different: declaration 'tgt' definition 'side'. [funcArgNamesDifferent] const struct flowside *side) ^ flow.h:176:31: note: Function 'flowside_sock_l4' argument 4 names different: declaration 'tgt' definition 'side'. const struct flowside *tgt); ^ flow.c:216:31: note: Function 'flowside_sock_l4' argument 4 names different: declaration 'tgt' definition 'side'. const struct flowside *side) ^ pif.c:111:10: error: Overlapping read/write of union is undefined behavior [overlappingWriteUnion] ref.fd = sock_l4_dualstack_any(c, ref.type, port, ifname); ^ pif.c:116:10: error: Overlapping read/write of union is undefined behavior [overlappingWriteUnion] ref.fd = sock_l4(c, ref.type, &sa, ifname); ^ --- ...is it just my version (2.19.0)? -- Stefano