Re: [PATCH 0/3] Fix broken build with -DNDEBUG

On Sat, May 16, 2026 at 05:46:44PM +0200, Stefano Brivio wrote:

On Fri, 15 May 2026 14:13:09 +1000 David Gibson wrote:

...

Fix the trivial but nasty with -DNDEBUG builds recently reported by Jan Palus. While we're there, add a couple of extra build tests. These wouldn't actually catch this problem, but they're better than nothing and do catch the #include problem I also spotted.

David Gibson (3): test: Extend exeter build tests to cover more recent binaries Fix build with -DNDEBUG test: Add test for builds with -DNDEBUG

Applied, with 2/3 amended as suggested by Jan.

Uh.. I'm afraid you modified the wrong copy of assert_with_msg(), effectively nixing asserts in the !NDEBUG case while leaving my implementation in the NDEBUG case.

Jan, I'll let you know once I tag a new release so that you can drop your no-assert.patch.

I'm trying to figure out, first, a couple of potential regressions (https://bugs.passt.top/show_bug.cgi?id=202, https://bugs.passt.top/show_bug.cgi?id=203) so that those can be fixed in the new release as well, but it might be a while before I even get to look into them, and I won't wait more than a few days with a new release in any case.

-- Stefano

-- David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson