On Tue, 9 Jun 2026 12:32:22 +1000
David Gibson
While working on podman bug 23739, I found some deficiences in how and when we report various socket errors related to specific flows. Here are some preliminary patches to improve that.
I think patches 1..3 are pretty straightforward and safe. 4/4 I think is a good idea in principle - promoting the priority of a number of messages now that we have ratelimiting. However, plumbing 'now' all the places we need it resuls in a *lot* of churn, so we might want to postpone or split it up.
Unless I'm missing something, I don't see 4/4 as particularly problematic. It's a set of rather mechanical changes where the compiler would tell us if we got something wrong, I guess?
Still, current drafted posted for consideration.
David Gibson (4): flow: Regularise flow specific logging helpers flow: Include flow details with higher priority log messages flow: Safer errno handling in flowside_connect() callers flow, treewide: Promote priority of selected flow-linked messages
flow.c | 107 +++++++------- flow.h | 72 +++++----- icmp.c | 27 ++-- icmp.h | 3 +- migrate.c | 27 ++-- migrate.h | 8 +- passt.c | 8 +- tcp.c | 381 ++++++++++++++++++++++++++++--------------------- tcp.h | 5 +- tcp_buf.c | 78 +++++----- tcp_buf.h | 8 +- tcp_conn.h | 8 +- tcp_internal.h | 27 ++-- tcp_splice.c | 59 +++++--- tcp_splice.h | 3 +- tcp_vu.c | 42 +++--- tcp_vu.h | 6 +- udp.c | 48 ++++--- udp_flow.c | 22 +-- 19 files changed, 535 insertions(+), 404 deletions(-)
-- Stefano