On Tue, Nov 17, 2026 at 12:04:28PM +0100, Stefano Brivio wrote:
On Thu, 12 Nov 2026 17:09:20 +0100 Lynxes Exe
wrote: Hi Stefano,
I apologize for the long wait. The issue took a while to represent itself.
No worries, it wasn't that long, thanks for following up.
[...]
3. Patches
Attached, against current master (7380393):
0001 tcp: Don't add peers to low RTT table before RTT is measured 0002 tcp: Log additions to low RTT table
0001 is your condition as you wrote it. 0002 logs only additions, with flow_dbg(): the skip itself happens on every tcp_prepare_flags() call until the first sample, which was 28 times for one connection in the test above, so logging it would be noisy. Each patch builds without warnings; I haven't run the test suite.
Thanks for the patches, and welcome to the git log!
I was about to merge both, but there's an issue with the first one, so I could just merge 2/2 for the moment. I'm fairly confident that 1/2 is actually correct, but it makes the migrate/rampstream_out test fail.
The migration functionality gives a hypervisor (currently this is only supported with QEMU) a way to "move" all our context, including TCP connections (!), between a source guest and a target guest, so that virtual machines can be moved to another host as they are, with a short interruption. The stages_v2[] array in migrate.c gives an overview of what data can move to another instance of passt, and how.
That test checks that an outbound stream sent by a guest remains consistent as it's moved from a source instance to a target instance of passt. With 1/2, the flow appears to stop mid way, or to not restart on the destination.
We don't copy the "low RTT" table during migration. I didn't think it was needed, because, I thought, eventually the destination instance of passt should figure things out. But it looks like it doesn't, and that bug with the initial ~0U value hid the issue until now, that is, (some?) migrated connections are _probably_ inserted by default in the table. This is just a wild guess for the moment.
Seems like there's a real bug here, but just migrating the low RTT table doesn't seem correct either: whether things are "local" or not could change because of the migration. -- David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson