On Wed, Sep 17, 2025 at 08:41:42AM +0200, Laurent Vivier wrote:

The dhcp() function wasn't following the inverted Christmas tree variable declaration ordering convention.

Signed-off-by: Laurent Vivier

Reviewed-by: David Gibson

--- dhcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dhcp.c b/dhcp.c index 012cec6c0d04..6b9c2e3b9e5a 100644 --- a/dhcp.c +++ b/dhcp.c @@ -311,10 +311,10 @@ int dhcp(const struct ctx *c, struct iov_tail *data) const struct ethhdr *eh; const struct iphdr *iph; const struct udphdr *uh; + struct msg m_storage; struct msg const *m; struct msg reply; unsigned int i; - struct msg m_storage;

eh = IOV_REMOVE_HEADER(data, eh_storage); iph = IOV_PEEK_HEADER(data, iph_storage); -- 2.50.1

-- David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson