On Wed, Jun 17, 2026 at 02:21:03PM +0200, Laurent Vivier wrote:

The original siphash incremental patch added a u64[2] member to union inany_addr for hashing. During review, this was changed to u32[4] to preserve 4-byte alignment: a u64 member would have forced 8-byte alignment on the union, mismatching struct in6_addr.

The doc comment was not updated, fix @u64 references to @u32.

Fixes: fc8f0f8c48ef ("siphash: Use incremental rather than all-at-once siphash functions") Signed-off-by: Laurent Vivier

Reviewed-by: David Gibson

--- inany.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/inany.h b/inany.h index 73385b916240..6bf3ecaa0e7d 100644 --- a/inany.h +++ b/inany.h @@ -22,9 +22,9 @@ * @v4mapped.zero: All zero-bits for an IPv4 address * @v4mapped.one: All one-bits for an IPv4 address * @v4mapped.a4: If @a6 is an IPv4 mapped address, the IPv4 address - * @u64: As an array of u64s (solely for hashing) + * @u32: As an array of u32s (solely for hashing) * - * @v4mapped and @u64 shouldn't be accessed except via helpers. + * @v4mapped and @u32 shouldn't be accessed except via helpers. */ union inany_addr { struct in6_addr a6; -- 2.54.0

-- David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson