Re: [PATCH] conf, pasta: Make -g and -a skip route/addresses copy for matching IP version only

On 06/08/2024 20:38, Stefano Brivio wrote:

Paul reports that setting IPv4 address and gateway manually, using --address and --gateway, causes pasta to fail inserting IPv6 routes in a setup where multiple, inter-dependent IPv6 routes are present on the host.

That's because, currently, any -g option implies --no-copy-routes altogether, and any -a implies --no-copy-addrs.

Limit this implication to the matching IP version, instead, by having two copies of no_copy_routes and no_copy_addrs in the context structure, separately for IPv4 and IPv6.

While at it, change them to 'bool': we had them as 'int' because getopt_long() used to set them directly, but it hasn't been the case for a while already.

Reported-by: Paul Holzinger Signed-off-by: Stefano Brivio

Tested-by: Paul Holzinger I got confused for a moment because `pasta --config-net ip -6 route` did not show any routes, well turns out the -6 was parsed by pasta so I had to do `pasta --config-net -- ip -6 route` and it works as expected now.

--- conf.c | 32 ++++++++++++++++++++------------ passt.1 | 4 ++-- passt.h | 14 ++++++++++---- pasta.c | 8 ++++---- 4 files changed, 36 insertions(+), 22 deletions(-)

-- Paul Holzinger