In tcp_seq_init() the meaning of "src" and "dst" isn't really
clear since
it's used for connections in both directions. However, these values are
just feeding a hash, so as long as we're consistent and include all the
information we want, it doesn't really matter.
Oddly, for the "src" side we supply the (tap side) forwarding address but
the (tap side) endpoint port. This again doesn't really matter, but it's
confusing. So swap this with dstport, so "src" is always forwarding
and "dst" is always endpoint.
Signed-off-by: David Gibson <david(a)gibson.dropbear.id.au>
---
tcp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tcp.c b/tcp.c
index 74bf744..56634c9 100644
--- a/tcp.c
+++ b/tcp.c
@@ -1857,8 +1857,8 @@ static void tcp_seq_init(const struct ctx *c, struct tcp_tap_conn
*conn,
in_port_t dstport;
} __attribute__((__packed__)) in = {
.src = conn->faddr,
- .srcport = conn->eport,
- .dstport = conn->fport,
+ .srcport = conn->fport,
+ .dstport = conn->eport,
};
uint32_t ns, seq = 0;
--
2.41.0