So I started hitting some clang-tidy warnings with LLVM 16, some
looked bogus, so I upgraded to LLVM 19, and... I got even more. This
series takes care of them in different ways.
v5:
- ouch, it looks like I didn't test with 2/8 while rebasing this thing
back and forth... replace snprintf() with vsnprintf() there,
otherwise nothing works
v4:
- drop 5/9 and keep O_APPEND for the log file, turned off around log
rotation, so that a hypothetical log file with multiple writers would
still be somewhat consistent
v3:
- split 5/8 into 5/9 and 6/9: in the first, drop O_APPEND so that we can
have a helper to open any output file we need, and in the second one,
always use O_CLOEXEC for pcap file (and use the new helper, now that
we can)
v2:
- make snprintf_check() return and set errno on failure, in 2/8
- add missing err_perror() calls on clock_gettime() failures in 6/8
- drop all explicit integer assignments in enum udp_iov_idx in 7/8
Stefano Brivio (8):
Makefile: Exclude qrap.c from clang-tidy checks
treewide: Comply with CERT C rule ERR33-C for snprintf()
treewide: Silence cert-err33-c clang-tidy warnings for fprintf()
Makefile: Disable readability-math-missing-parentheses clang-tidy
check
treewide: Suppress clang-tidy warning if we already use O_CLOEXEC
treewide: Address cert-err33-c clang-tidy warnings for clock and timer
functions
udp: Take care of cert-int09-c clang-tidy warning for enum udp_iov_idx
util: Don't use errno after a successful call in __daemon()
Makefile | 13 +++++++---
arch.c | 6 ++++-
conf.c | 64 +++++++++++++++++++++++++++----------------------
log.c | 9 ++++---
passt.c | 9 ++++---
pasta.c | 11 ++++++---
pcap.c | 24 ++++++++++---------
tap.c | 5 ++--
tcp.c | 12 +++++++---
udp.c | 10 ++++----
util.c | 72 ++++++++++++++++++++++++++++++++++++--------------------
util.h | 7 +++++-
12 files changed, 151 insertions(+), 91 deletions(-)
--
2.43.0