Re: [PATCH 2/2] fedora: Add selinux-policy Requires: tag

On Fri, Sep 02, 2022 at 05:47:34PM +0200, Stefano Brivio wrote:

On Fri, 2 Sep 2022 16:43:39 +0100 Daniel P. Berrangé wrote:

...

On Fri, Sep 02, 2022 at 05:38:42PM +0200, Stefano Brivio wrote:

...

fedora-review says:

Note: Directories without known owners: /usr/share/selinux/packages/passt, /usr/share/doc/passt, /usr/share/selinux, /usr/share/selinux/packages

and selinux-policy owns those two last ones.

Reported-by: Daniel P. Berrangé Signed-off-by: Stefano Brivio --- contrib/fedora/passt.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/fedora/passt.spec b/contrib/fedora/passt.spec index 1e328e2..f9fd0ab 100644 --- a/contrib/fedora/passt.spec +++ b/contrib/fedora/passt.spec @@ -34,7 +34,7 @@ requiring any capabilities or privileges. %package selinux BuildArch: noarch Summary: SELinux support for passt and pasta -Requires: %{name} = %{version}-%{release} +Requires: selinux-policy, %{name} = %{version}-%{release}

It isn't a requirement, but my preference would be separate Requires line for each dep, as it makes the spec more readable.

...

Requires(post): policycoreutils, %{name} Requires(preun): policycoreutils, %{name}

...for consistency, should I then change these two (post, preun) as well? It starts looking a bit "long" though. Or are those special somehow?

I would split them yes. Length isn't really a concern - if anything, the more packages you have in Requires, the more important it is to split them each on one line, and even alphabetically sort them (though I'd keep %{name} first if sorting as its special) With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|