We already had a couple of places we were working around clang-tidy
issue 58992, and the flow table series adds more. I got sick of ugly
inlines every time we used a syscall which returns a socket address,
so wrote a patch to consolidate the workarounds in one place.
However, that patch added an include of to util.h which
exposed a classic C library gotcha in packet.c, so I fixed that too.
Changes since v1:
* Updated missed comment to match code changes in 1/2
* Fixed more places which shadowed index(3)
David Gibson (2):
Avoid shadowing index(3)
util: Consolidate and improve workarounds for clang-tidy issue 58992
Makefile | 2 +-
icmp.c | 5 -----
packet.c | 30 +++++++++++++++---------------
packet.h | 10 +++++-----
tcp.c | 22 ++++++++--------------
tcp_splice.c | 2 +-
util.c | 12 ++++++------
util.h | 43 ++++++++++++++++++++++++++++++++++++++++++-
8 files changed, 78 insertions(+), 48 deletions(-)
--
2.41.0