Re: [PATCH v2 1/3] conf, fwd: Make ephemeral port logic more flexible

On Thu, Aug 29, 2024 at 06:59:05AM +0200, Stefano Brivio wrote:

Nit:

On Thu, 29 Aug 2024 11:32:40 +1000 David Gibson wrote:

...

+/* Empheral port range: values from RFC 6335 */ +static const uint16_t fwd_ephemeral_min = (1 << 15) + (1 << 14); +static const uint16_t fwd_ephemeral_max = NUM_PORTS - 1;

Maybe you could use in_port_t instead, just for consistency with (almost) everything else, no advantages otherwise.

Duh, of course. -- David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson