Re: [PATCH 2/6] flow, tcp_splice: Prefer 'sidei' for variables referring to side index

On Wed, 17 Jul 2024 14:52:19 +1000
David Gibson <david(a)gibson.dropbear.id.au> wrote:

...
  @@ -164,17 +164,17 @@ struct flow_common {
  
  /**
   * struct flow_sidx - ID for one side of a specific flow
 - * @side:	Side referenced (0 or 1)
 + * @side:	Index of side referenced (0 or 1)
   * @flow:	Index of flow referenced 
Nit (I can fix this up on merge, and I didn't finish reviewing yet):
the comment to the struct should also use sidei/flowi.

...
    */
  typedef struct flow_sidx {
 -	unsigned	side :1;
 -	unsigned	flow :FLOW_INDEX_BITS;
 +	unsigned	sidei :1;
 +	unsigned	flowi :FLOW_INDEX_BITS;
  } flow_sidx_t; 
-- 
Stefano