On Mon, Nov 17, 2025 at 04:26:43PM +0100, Laurent Vivier wrote:
On 11/10/25 05:48, David Gibson wrote:
index aa7c869d9e56..c668159e29b4 100644 --- a/vhost_user.c +++ b/vhost_user.c @@ -323,6 +323,7 @@ static bool vu_get_features_exec(struct vu_dev *vdev, uint64_t features = 1ULL << VIRTIO_F_VERSION_1 | 1ULL << VIRTIO_NET_F_MRG_RXBUF | + 1ULL << VIRTIO_NET_F_MQ | Should this be conditional on max_virtqueues > 2?
I don't think it's needed as 1 qpair (2 virtqueues) is a valid value with VIRTIO_NET_F_MQ:
https://docs.oasis-open.org/virtio/virtio/v1.3/csd01/virtio-v1.3-csd01.html#...
"The device MUST set max_virtqueue_pairs to between 1 and 0x8000 inclusive, if it offers VIRTIO_NET_F_MQ."
Ok, that makes sense. I think I forgot this was offered features, not required features. -- David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson