Re: [PATCH 24/28] cppcheck: Remove unused knownConditionTrueFalse suppression

On Wed, Sep 28, 2022 at 10:58:25PM +0200, Stefano Brivio wrote:

On Wed, 28 Sep 2022 14:33:35 +1000 David Gibson wrote:

...

I can't get this warning to trigger, so I think this suppression must be out of date. Whether that's because we've changed our code to no longer have the problem, or because cppcheck itself has been updated to remove a false positive I don't know.

The former: you got rid of that case with the rework of the PID parsing.

Hmm... I couldn't manage to trip the warning even if I went back before that rework. I did only try cppcheck-2.7 though. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson