Here are some more pointers which can be const, as reported by cppcheck
2.19.1.
Signed-off-by: David Gibson
---
conf.c | 2 +-
dhcpv6.c | 3 ++-
vhost_user.c | 2 +-
3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/conf.c b/conf.c
index b1fc4b9f..a242fda1 100644
--- a/conf.c
+++ b/conf.c
@@ -1224,7 +1224,7 @@ dns6:
*
* Return: 0 on success, negative error code on failure
*/
-static int conf_runas(char *opt, unsigned int *uid, unsigned int *gid)
+static int conf_runas(const char *opt, unsigned int *uid, unsigned int *gid)
{
const char *uopt, *gopt = NULL;
char *sep = strchr(opt, ':');
diff --git a/dhcpv6.c b/dhcpv6.c
index d94be23a..97c04e2c 100644
--- a/dhcpv6.c
+++ b/dhcpv6.c
@@ -320,7 +320,7 @@ static bool dhcpv6_opt(struct iov_tail *data, uint16_t type)
static bool dhcpv6_ia_notonlink(struct iov_tail *data,
struct in6_addr *la)
{
- int ia_types[2] = { OPT_IA_NA, OPT_IA_TA }, *ia_type;
+ int ia_types[2] = { OPT_IA_NA, OPT_IA_TA };
struct opt_ia_addr opt_addr_storage;
const struct opt_ia_addr *opt_addr;
struct iov_tail current, ia_base;
@@ -330,6 +330,7 @@ static bool dhcpv6_ia_notonlink(struct iov_tail *data,
struct in6_addr req_addr;
struct opt_hdr h_storage;
const struct opt_hdr *h;
+ const int *ia_type;
foreach(ia_type, ia_types) {
current = *data;
diff --git a/vhost_user.c b/vhost_user.c
index 1e320bff..9fe12411 100644
--- a/vhost_user.c
+++ b/vhost_user.c
@@ -442,7 +442,7 @@ static bool vu_set_mem_table_exec(struct vu_dev *vdev,
for (i = 0; i < vdev->memory.nregions; i++) {
struct vhost_user_memory_region *msg_region = &memory->regions[i];
struct vu_dev_region *dev_region = &vdev->memory.regions[i];
- void *mmap_addr;
+ const void *mmap_addr;
debug("vhost-user region %d", i);
debug(" guest_phys_addr: 0x%016"PRIx64,
--
2.52.0