On Wed, Jan 04, 2023 at 06:45:16PM +0100, Stefano Brivio wrote:On Fri, 9 Dec 2022 16:42:15 +1100 David Gibson <david(a)gibson.dropbear.id.au> wrote:Fixed.Currently this takes a msghdr, but the only thing we actually care about in there in is the io vector. Make it take an io vector directly. We alsos/in is/is/, if you re-spin.Hm, I guess. It seemed odd to me because most of the rest of the management of the buf_used variables is open coded in the caller.have a weird side effect of zeroing @buf_used. Just pass this by value and zero it in the caller instead.That was done on purpose: call a "flush" function, and that will set the right value for @buf_used.On the other hand, after 3/18, I think both options are equally readable, and if you found it weird, so be it.More to the point I think the old way obstructed the changes I make later in the series. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson