Re: [PATCH] seccomp.sh: Silence stty errors

On Mon, Feb 24, 2025 at 08:38:24AM +0100, Stefano Brivio wrote:

On Mon, 24 Feb 2025 13:05:40 +1100 David Gibson wrote:

...

On Fri, Feb 21, 2025 at 12:53:13PM +0100, Michal Privoznik wrote:

...

When printing list of allowed syscalls the width of terminal is obtained for nicer output (see commit below). The width is obtained by running 'stty'. While this works when building from a console, it doesn't work during rpmbuild/emerge/.. as stdout is usually not a console but a logfile and stdin is usually /dev/null or something. This results in stty reporting errors like this:

stty: 'standard input': Inappropriate ioctl for device

Redirect stty's stderr to /dev/null to silence it.

Fixes: 712ca3235329b049bf9a4e481ba38a4c64768e8b Signed-off-by: Michal Privoznik

Reviewed-by: David Gibson

Although, I also wonder if we'd do just as well to use the shell provided $COLUMNS variable without poking at the terminal ourselves.

No, because that's a Bash/KSH thing. At least ash, dash and csh don't have it.

Having marginally uglier formatting in those shells doesn't strike me as a disaster. -- David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson