Re: [PATCH] tcp: Properly remove sockets from epoll loop when connection is closed

On Tue, 11 Nov 2025 14:25:20 +1100 David Gibson wrote:

Most of the handling for closing a TCP connectin is in conn_event_do() when it receives a 'CLOSED' event. We specifically check for this case and, correctly, remove the connection from the flow hash table. However, we also bypass the call tp tcp_epoll_ctl() which is not correct. By skipping tcp_epoll_ctl() we skip it's specific handling of the CLOSED event, which includes removing the TCP socket from epoll.

If we somehow get an event on such a stale socket, we'll get a stale flow reference. That flow slot might have been re-used, leading to to a crash in conn_at_sidx().

Fixes: b86afe3559c0 ("tcp: Don't defer hash table removal") Signed-off-by: David Gibson

Applied. -- Stefano