On Tue, Mar 18, 2025 at 08:57:45PM +0100, Stefano Brivio wrote:Fixes: 04701702471e ("passt-repair: Add directory watch") Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>Reviewed-by: David Gibson <david(a)gibson.dropbear.id.au>--- Note: I just pushed this for my own sanity, as it's trivial and builds are otherwise broken on CentOS Stream / RHEL. I'm posting for review anyway in the unlikely case something can ever be wrong with this.Looks like a good idea. Wonder if it's a good idea to turn on -Wformat-security for upstream builds.passt-repair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/passt-repair.c b/passt-repair.c index 8bb3f00..120f7aa 100644 --- a/passt-repair.c +++ b/passt-repair.c @@ -150,7 +150,7 @@ int main(int argc, char **argv) _exit(1); } - ret = snprintf(a.sun_path, sizeof(a.sun_path), path); + ret = snprintf(a.sun_path, sizeof(a.sun_path), "%s", path); inotify_dir = true; } else { ret = snprintf(a.sun_path, sizeof(a.sun_path), "%s", argv[1]);-- David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson