Re: [PATCH 00/14] RFC: tcp: Don't use separate listening sockets for spliced and non-spliced connections

On Tue, Nov 15, 2022 at 02:22:41AM +0100, Stefano Brivio wrote:

On Mon, 14 Nov 2022 17:16:57 +1100 David Gibson wrote:

...

We can splice TCP connections in pasta mode if and only if they originate from localhost. Currently we separate the two cases by having separate listening sockets: one listens on the host address for non-spliceable connections, the other listens on the loopback address for spliceable connections.

I couldn't finish reviewing the whole series in detail yet, but I had a look at all the patches and, except for a couple of minor style issues (those are the ones I still need to finish checking), I couldn't see any flaw -- all the single patches look fine to me.

Ok. Probably not worth looking deeper at this stage. I'm pretty close to sending a new series which contains a slightly revised version of this, plus the rest of the stuff necessary to do dual stack TCP sockets. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson