conf_ports() has logic to warn if -[TU] auto is specified but we can't use
SO_BINDTODEVICE. However, this is redundant with similar logic in
conf_ports_range_except(). The latter will be triggered both for an
explicit -[TU] auto and when it's invoked as a default option, so keep that
one and drop the one in conf_ports().
Signed-off-by: David Gibson
---
conf.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/conf.c b/conf.c
index d4c2a013..5639ef03 100644
--- a/conf.c
+++ b/conf.c
@@ -249,12 +249,6 @@ static void conf_ports(const struct ctx *c, char optname, const char *optarg,
if (c->mode != MODE_PASTA)
die("'auto' port forwarding is only allowed for pasta");
- if ((optname == 'T' || optname == 'U') && c->no_bindtodevice) {
- warn(
-"'-%c auto' enabled without unprivileged SO_BINDTODEVICE", optname);
- warn(
-"Forwarding from addresses other than 127.0.0.1 will not work");
- }
*mode = FWD_MODE_AUTO;
return;
}
--
2.53.0