Re: [PATCH 03/14] nstool: Move description of its operation modes from comment to usage

On Wed, Apr 05, 2023 at 01:56:59PM +0200, Stefano Brivio wrote:

On Tue, 4 Apr 2023 11:46:27 +1000 David Gibson wrote:

...

Easier to see it there.

Signed-off-by: David Gibson --- test/nstool.c | 26 +++++++++++--------------- 1 file changed, 11 insertions(+), 15 deletions(-)

diff --git a/test/nstool.c b/test/nstool.c index cc6d617..7e069b6 100644 --- a/test/nstool.c +++ b/test/nstool.c @@ -4,20 +4,6 @@ * * Copyright Red Hat * Author: David Gibson - * - * Can run in 3 modes: - * - * nstool hold <path> - * Designed to be run inside a namespace, opens a Unix domain - * control socket at <path> and waits until instructed to stop - * with "nstool stop <path>" - * nstool pid <path> - * Prints the PID of the nstool hold process with control socket - * <path>. This is given in the PID namespace where nstool pid - * is executed, not the one where nstool hold is running - * nstool stop <path> - * Instruct the nstool hold with control socket at <path> to - * exit. */

#define _GNU_SOURCE @@ -38,7 +24,17 @@

static void usage(void) { - die("Usage: nstool hold|pid|stop <socket path>\n"); + die("Usage:\n" + " nstool hold SOCK\n" + " Run within a set of namespaces, open a Unix domain control\n"

UNIX domain socket

Adjusted. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson