On Thu, Nov 27, 2025 at 10:20:37AM +0100, Laurent Vivier wrote:
On 11/26/25 04:45, David Gibson wrote:
+ + if [ ${VHOST_USER_MQ} -gt 1 ]; then + __qemu_netdev="${__qemu_netdev} \ + -device virtio-net,netdev=v,mq=true \ + -netdev vhost-user,id=v,chardev=c,queues=${VHOST_USER_MQ}" + else + __qemu_netdev="${__qemu_netdev} \ + -device virtio-net,netdev=v \ + -netdev vhost-user,id=v,chardev=c" Is there a diffence for qemu between omitting queues= and using queues=1? If not we can simplify this. For the passt option it's worth explicitly not-setting it for the single-queue case, so that we're exercising the command line option as well. But exercising qemu's options is not our concern, so we can use queues=1 if it means the same thing as omitting it entirely.
I think the important parameter here is mq=true that will set or not the feature. This exercise the interface between QEMU and passt.
Ah, good point, I missed that.
I will try to see if we can set queues unconditionally (with 1 or more).
Thanks, Laurent
-- David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson