Re: [PATCH 3/6] util: Add write_remainder() helper

On Wed, 28 Feb 2024 11:44:28 +1100 David Gibson wrote:

On Tue, Feb 27, 2024 at 03:25:51PM +0100, Stefano Brivio wrote:

...

On Thu, 22 Feb 2024 16:55:59 +1100 David Gibson wrote:

[...]

...

+ + if (skip)

Curly brackets here for consistency (undecided about readability to be honest).

Uh.. consistency with what? We don't typically brace single line clauses in passt.

...

...

+ rc = write(fd, (char *)iov[i].iov_base + skip, + iov[i].iov_len - skip);

These are two lines though. I've been trying to keep this consistent with the Linux kernel's net/ and drivers/net/ style, where curly braces are used for multiple lines, even if it's a single statement. -- Stefano