[PATCH trivial 2/3] tcp_vu: Remove redundant eh->h_source assignment in tcp_vu_send_flag()

tcp_fill_headers() calls eth_update_mac(eh, NULL, omac) which unconditionally overwrites eh->h_source. The prior memcpy() setting it to c->our_tap_mac is therefore redundant. Signed-off-by: Laurent Vivier --- tcp_vu.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tcp_vu.c b/tcp_vu.c index c616b1fec2bf..9c4e916b1b8d 100644 --- a/tcp_vu.c +++ b/tcp_vu.c @@ -102,7 +102,6 @@ int tcp_vu_send_flag(const struct ctx *c, struct tcp_tap_conn *conn, int flags) eh = vu_eth(flags_elem[0].in_sg[0].iov_base); memcpy(eh->h_dest, c->guest_mac, sizeof(eh->h_dest)); - memcpy(eh->h_source, c->our_tap_mac, sizeof(eh->h_source)); if (CONN_V4(conn)) { ip4h = vu_ip(flags_elem[0].in_sg[0].iov_base); -- 2.53.0