Re: [PATCH v2 0/4] Some cleanups to tap and tcp

On Fri, 17 Feb 2023 09:55:59 +1100 David Gibson wrote:

On Thu, Feb 16, 2023 at 11:22:07PM +0100, Stefano Brivio wrote:

...

On Thu, 16 Feb 2023 16:43:07 +1100 David Gibson wrote:

...

This is a handful of simple cleanups which I made while investigating https://bugs.passt.top/show_bug.cgi?id=41. Note that these don't themselves actually address that bug, they're just unrelated cleanups that happen to be in adjacent code.

I've run basic tests on these, but not quite the complete test suite: I haven't yet had a chance to debug an unrelated problem with the IPv4 performance tests failing.

Changes since v1: * Minor comment and style fixes

David Gibson (4): tap: Don't pcap frames that didn't get sent tap: Eliminate goto from tap_handler() tcp: Remove 'recvmsg' goto from tcp_data_from_sock tcp: Remove 'zero_len' goto from tcp_data_from_sock

Applied.

Hmm.. I'm not seeing them in the tree yet..

Oops, yes, I actually pushed it a few minutes after you sent this email... -- Stefano