Re: [PATCH] tcp: Move tap header update out of tcp_fill_headers()

On Tue, 10 Feb 2026 17:08:21 +0100 Laurent Vivier wrote:

tcp_fill_headers() currently calls tap_hdr_update() to set the frame length in the tap-specific header. This is backend-specific: the tap backend needs this for its frame length header, but the vhost-user backend passes NULL for the tap header and doesn't use it at all.

Remove the tap_hdr parameter from tcp_fill_headers() and instead return the computed L2 frame length. The tap backend caller, tcp_l2_buf_fill_headers(), now calls tap_hdr_update() itself with the returned length. The vhost-user callers, tcp_vu_send_flag() and tcp_vu_prepare(), no longer need to pass a NULL tap header.

Signed-off-by: Laurent Vivier

Applied. -- Stefano