The most pressing problem fixed here is that spliced connections with
a remapped destination port would be attempted on the wrong side. This
is an old issue as indicated by the Fixes: tag.
Patch 1/3 restores sanity in comments before we attempt to fix the
issue, patch 2/3 fixes the actual issue, and patch 3/3 introduces
a minor rework on top to fix another issue, where if the user
explicitly configures a loopback address in a port binding we would
still create a non-spliced socket stealing the related connections.
v2:
- rewrite 2/3 with David's idea of using bit in epoll reference
- rebase, and use IPV4_IS_LOOPBACK in tcp_conn_from_sock() too
Stefano Brivio (3):
tcp, tcp_splice: Adjust comments to current meaning of inbound and
outbound
tcp, tcp_splice: Fix port remapping for inbound, spliced connections
Don't create 'tap' socket for ports that are bound to loopback only
tcp.c | 192 +++++++++++++++++++++++++++++++--------------------
tcp.h | 2 +
tcp_splice.c | 22 +++---
util.h | 3 +
4 files changed, 137 insertions(+), 82 deletions(-)
--
2.35.1