Re: [PATCH] Add pyramid style rule to CONTRIBUTING.md

On Thu, 23 Oct 2025 11:40:10 +1100 David Gibson wrote:

On Wed, Oct 22, 2025 at 12:30:54PM +0800, Yumei Huang wrote:

...

Also fix the copyright line.

Suggested-by: Stefano Brivio Signed-off-by: Yumei Huang

Stefano, do we actually encourage that style for any "list of similar items"? Or just for local variable declarations?

Just for local variable declarations, thanks for noticing. I was rather focusing on the fact (https://lwn.net/Articles/758552/) that it's actually called "Reverse Christmas tree", not pyramid style. I can't find a convenient reference right now, maybe it's hidden somewhere in https://lore.kernel.org/netdev/?q=reverse+christmas+tree, ...or maybe it's actually "documented" in checkpatch.pl? Or prehaps just trust us/me on that, sorry, I know it's not ideal :( ...but I can absolutely guarantee it's called Reverse Christmas tree. -- Stefano