Re: [PATCH] dhcp: Remove option 255 length byte

On Wed, Feb 12, 2025 at 2:38 AM Stefano Brivio wrote:

On Wed, 12 Feb 2025 12:14:32 +1100 David Gibson wrote:

...

On Tue, Feb 11, 2025 at 12:14:34PM +0100, Enrique Llorente wrote:

...

The option 255 (end of options) do not need the length byte, this change remove that allowing to have one extra byte at other dynamic options.

Signed-off-by: Enrique Llorente

Thanks, change is good. However, could you also update the comment on OPT_MAX's definition that appears to have the same error in it.

I was about to apply this by amending the comment, but... it's not just the comment (hence it needs to be re-tested a bit): OPT_MAX should be 307 now, otherwise you don't actually use the extra byte.

Good catch, changing.

-- Stefano

-- Quique Llorente CNV networking Senior Software Engineer Red Hat EMEA ellorent@redhat.com @RedHat Red Hat Red Hat