Re: [PATCH 1/2] Revert "udp: Make rport calculation more local"

On Mon, 24 Jun 2024 11:20:48 +1000 David Gibson wrote:

On Fri, Jun 21, 2024 at 05:53:22PM +0200, Stefano Brivio wrote:

...

This reverts commit c80fa6a6bb4415ad48f9e11424310875d0d99bc7, as it reintroduces the issue fixed by commit 1e6f92b995a9 ("udp: Fix 16-bit overflow in udp_invert_portmap()").

Reported-by: Laurent Jacquot Link: https://bugs.passt.top/show_bug.cgi?id=80 Signed-off-by: Stefano Brivio

Argh, dammit. So,

Reviewed-by: David Gibson

.. but I think we really need to put a comment on this, otherwise one of us is likely to make the same mistake again, because that particular promotion rule is truly arcane.

Pushed with a comment (part of commit for 2/2), I hope it's clear enough now. -- Stefano