Re: [PATCH 1/6] Makefile: Avoid using wildcard sources

On Tue, 14 Jun 2022 15:12:21 +1000 David Gibson wrote:

The passt/pasta Makefile makes fairly heavy use of GNU make's $(wildcard) function to locate the sources and headers to build. Using wildcards for the things to compile is usually a bad idea though: if somehow you end up with a .c or .h file in your tree you didn't expect it can misbuild in an exceedingly confusing way. In particular this can sometimes happen if switching between releases / branches where files have been added or removed without 100% cleaning the tree.

Thanks for fixing this, I have to admit I hit this very issue all the time ;) -- Stefano