Re: [RFC v3] tcp: Replace TCP buffer structure by an iovec array

On 3/21/24 02:26, David Gibson wrote:
...
  On Wed, Mar 20, 2024 at 05:31:46PM +0100, Laurent
Vivier wrote:
  To be able to provide pointers to TCP headers and
IP headers without
 worrying about alignment in the structure, split the structure into
 several arrays and point to each part of the frame using an iovec array.

 Using iovec also allows us to simply ignore the first entry when the
 vnet length header is not needed.

 Signed-off-by: Laurent Vivier <lvivier(a)redhat.com> 
 
 [snip]
  +static_assert(MSS4 <=
sizeof(tcp4_payload[0].data)); 
 
 This generates a clang-tidy warning, because apparently the C11
 version of static_assert() requires a message - making it optional is
 a C2x extension.
 
 Laurent, I know you're having trouble getting the full testsuite to
 run (but some ideas on that later today, I hope).  But could you
 please add a "make cppcheck" and "make clang-tidy" to your pre-post
 routine.
  
I'll do.
Thank you to have checked that.
Are there any other commands to run before to send?
Something like scripts/chekpatch.pl we have in QEMU?

I have always the same problem with the test suite, even after a "make
realclean" in test 
(see attachment)
How to debug?

Thanks,
Laurent