So I started hitting some clang-tidy warnings with LLVM 16, some
looked bogus, so I upgraded to LLVM 19, and... I got even more. This
series takes care of them in different ways.
v2:
- make snprintf_check() return and set errno on failure, in 2/8
- add missing err_perror() calls on clock_gettime() failures in 6/8
- drop all explicit integer assignments in enum udp_iov_idx in 7/8
Stefano Brivio (8):
Makefile: Exclude qrap.c from clang-tidy checks
treewide: Comply with CERT C rule ERR33-C for snprintf()
treewide: Silence cert-err33-c clang-tidy warnings for fprintf()
Makefile: Disable readability-math-missing-parentheses clang-tidy
check
treewide: Suppress clang-tidy warning if we already use O_CLOEXEC or
if we can't
treewide: Address cert-err33-c clang-tidy warnings for clock and timer
functions
udp: Take care of cert-int09-c clang-tidy warning for enum udp_iov_idx
util: Don't use errno after a successful call in __daemon()
Makefile | 13 ++++++++++---
arch.c | 6 +++++-
conf.c | 59 ++++++++++++++++++++++++++++++--------------------------
log.c | 10 +++++++---
passt.c | 9 ++++++---
pasta.c | 11 ++++++++---
pcap.c | 18 +++++++++++------
tap.c | 5 +++--
tcp.c | 12 +++++++++---
udp.c | 10 +++++-----
util.c | 49 ++++++++++++++++++++++++++++++++++++----------
util.h | 5 +++++
12 files changed, 141 insertions(+), 66 deletions(-)
--
2.43.0