Re: [PATCH v2 05/10] Move self-isolation code into a separate file

On Fri, Sep 09, 2022 at 04:33:58PM +0200, Stefano Brivio wrote:
...
  On Thu,  8 Sep 2022 13:59:02 +1000
 David Gibson <david(a)gibson.dropbear.id.au> wrote:
 
  [...]

 +++ b/isolation.c

 [...]

 +/**
 + * sandbox() - Unshare IPC, mount, PID, UTS, and user namespaces, "unmount"
root
 + *
 + * Return: negative error code on failure, zero on success
 + */
 +int sandbox(struct ctx *c) 
 
 Same here, I would "document" "c". 
Not in scope for this patch, since it's a pure code motion.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson