Re: [PATCH 2/4] treewide: Improve robustness against sockaddrs of unexpected family

On Wed, 16 Apr 2025 19:07:05 +1000
David Gibson <david(a)gibson.dropbear.id.au> wrote:

...
  @@ -239,22 +239,28 @@ static inline void
inany_from_af(union inany_addr *aa,
  /** inany_from_sockaddr - Extract IPv[46] address and port number from sockaddr
   * @aa:		Pointer to store IPv[46] address
   * @port:	Pointer to store port number, host order
 - * @addr:	AF_INET or AF_INET6 socket address
 + * @addr:	Socket address 
This is actually sa_ now but... can we do something for argument names
in general, here? What about dst, port, sa, or dst, port, addr?

...
  + *
 + * Return: 0 on success, -1 on error (bad address family)
   */
 -static inline void inany_from_sockaddr(union inany_addr *aa, in_port_t *port,
 -				       const union sockaddr_inany *sa)
 +static inline int inany_from_sockaddr(union inany_addr *aa, in_port_t *port,
 +				      const void *sa_)
  {
 +	const union sockaddr_inany *sa = (const union sockaddr_inany *)sa_; 
-- 
Stefano